| Message ID | 20211012093446.1575-1-vegard.nossum@oracle.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | e599ee234ad4fdfe241d937bbabd96e0d8f9d868 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [v2] net: arc: select CRC32 | expand |
Hello: This patch was applied to netdev/net.git (master) by Jakub Kicinski <kuba@kernel.org>: On Tue, 12 Oct 2021 11:34:46 +0200 you wrote: > Fix the following build/link error by adding a dependency on the CRC32 > routines: > > ld: drivers/net/ethernet/arc/emac_main.o: in function `arc_emac_set_rx_mode': > emac_main.c:(.text+0xb11): undefined reference to `crc32_le' > > The crc32_le() call comes through the ether_crc_le() call in > arc_emac_set_rx_mode(). > > [...] Here is the summary with links: - [v2] net: arc: select CRC32 https://git.kernel.org/netdev/net/c/e599ee234ad4 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
diff --git a/drivers/net/ethernet/arc/Kconfig b/drivers/net/ethernet/arc/Kconfig index 37a41773dd435..92a79c4ffa2c7 100644 --- a/drivers/net/ethernet/arc/Kconfig +++ b/drivers/net/ethernet/arc/Kconfig @@ -21,6 +21,7 @@ config ARC_EMAC_CORE depends on ARC || ARCH_ROCKCHIP || COMPILE_TEST select MII select PHYLIB + select CRC32 config ARC_EMAC tristate "ARC EMAC support"
Fix the following build/link error by adding a dependency on the CRC32 routines: ld: drivers/net/ethernet/arc/emac_main.o: in function `arc_emac_set_rx_mode': emac_main.c:(.text+0xb11): undefined reference to `crc32_le' The crc32_le() call comes through the ether_crc_le() call in arc_emac_set_rx_mode(). [v2: moved the select to ARC_EMAC_CORE; the Makefile is a bit confusing, but the error comes from emac_main.o, which is part of the arc_emac module, which in turn is enabled by CONFIG_ARC_EMAC_CORE. Note that arc_emac is different from emac_arc...] Fixes: 775dd682e2b0ec ("arc_emac: implement promiscuous mode and multicast filtering") Cc: Arnd Bergmann <arnd@arndb.de> Signed-off-by: Vegard Nossum <vegard.nossum@oracle.com> --- drivers/net/ethernet/arc/Kconfig | 1 + 1 file changed, 1 insertion(+)