diff mbox series

net: korina: select CRC32

Message ID 20211012152509.21771-1-vegard.nossum@oracle.com (mailing list archive)
State Accepted
Commit 427f974d9727ca681085ddcd0530c97ab5811ae0
Delegated to: Netdev Maintainers
Headers show
Series net: korina: select CRC32 | expand

Checks

Context Check Description
netdev/cover_letter success Single patches do not need cover letters
netdev/fixes_present success Fixes tag not required for -next series
netdev/patch_count success Link
netdev/tree_selection success Guessed tree name to be net-next
netdev/subject_prefix warning Target tree name not specified in the subject
netdev/cc_maintainers fail 4 blamed authors not CCed: florian.fainelli@telecomint.eu jeff@garzik.org rischelp@idt.com nbd@openwrt.org; 8 maintainers not CCed: nbd@openwrt.org joel@jms.id.au tsbogend@alpha.franken.de florian.fainelli@telecomint.eu jeff@garzik.org rischelp@idt.com decui@microsoft.com cristian.ciocaltea@gmail.com
netdev/source_inline success Was 0 now: 0
netdev/verify_signedoff success Signed-off-by tag matches author and committer
netdev/module_param success Was 0 now: 0
netdev/build_32bit success Errors and warnings before: 0 this patch: 0
netdev/kdoc success Errors and warnings before: 0 this patch: 0
netdev/verify_fixes success Fixes tag looks correct
netdev/checkpatch success total: 0 errors, 0 warnings, 0 checks, 7 lines checked
netdev/build_allmodconfig_warn success Errors and warnings before: 0 this patch: 0
netdev/header_inline success No static functions without inline keyword in header files

Commit Message

Vegard Nossum Oct. 12, 2021, 3:25 p.m. UTC 
Fix the following build/link error by adding a dependency on the CRC32
routines:

  ld: drivers/net/ethernet/korina.o: in function `korina_multicast_list':
  korina.c:(.text+0x1af): undefined reference to `crc32_le'

Fixes: ef11291bcd5f9 ("Add support the Korina (IDT RC32434) Ethernet MAC")
Cc: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Vegard Nossum <vegard.nossum@oracle.com>
---
 drivers/net/ethernet/Kconfig | 1 +
 1 file changed, 1 insertion(+)

Comments

Florian Fainelli Oct. 12, 2021, 4:21 p.m. UTC | #1 
On 10/12/21 8:25 AM, Vegard Nossum wrote:
> Fix the following build/link error by adding a dependency on the CRC32
> routines:
> 
>   ld: drivers/net/ethernet/korina.o: in function `korina_multicast_list':
>   korina.c:(.text+0x1af): undefined reference to `crc32_le'
> 
> Fixes: ef11291bcd5f9 ("Add support the Korina (IDT RC32434) Ethernet MAC")
> Cc: Arnd Bergmann <arnd@arndb.de>
> Signed-off-by: Vegard Nossum <vegard.nossum@oracle.com>

Acked-by: Florian fainelli <f.fainelli@gmail.com>
patchwork-bot+netdevbpf@kernel.org Oct. 13, 2021, 8:40 p.m. UTC | #2 
Hello:

This patch was applied to netdev/net.git (master)
by Jakub Kicinski <kuba@kernel.org>:

On Tue, 12 Oct 2021 17:25:09 +0200 you wrote:
> Fix the following build/link error by adding a dependency on the CRC32
> routines:
> 
>   ld: drivers/net/ethernet/korina.o: in function `korina_multicast_list':
>   korina.c:(.text+0x1af): undefined reference to `crc32_le'
> 
> Fixes: ef11291bcd5f9 ("Add support the Korina (IDT RC32434) Ethernet MAC")
> Cc: Arnd Bergmann <arnd@arndb.de>
> Signed-off-by: Vegard Nossum <vegard.nossum@oracle.com>
> 
> [...]

Here is the summary with links:
  - net: korina: select CRC32
    https://git.kernel.org/netdev/net/c/427f974d9727

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
diff mbox series

Patch

diff --git a/drivers/net/ethernet/Kconfig b/drivers/net/ethernet/Kconfig
index d796684ec9ca0..412ae3e43ffb7 100644
--- a/drivers/net/ethernet/Kconfig
+++ b/drivers/net/ethernet/Kconfig
@@ -100,6 +100,7 @@  config JME
 config KORINA
 	tristate "Korina (IDT RC32434) Ethernet support"
 	depends on MIKROTIK_RB532 || COMPILE_TEST
+	select CRC32
 	select MII
 	help
 	  If you have a Mikrotik RouterBoard 500 or IDT RC32434