diff mbox series

lan78xx: select CRC32

Message ID 20211015130754.12283-1-vegard.nossum@oracle.com (mailing list archive)
State Accepted
Commit 46393d61a328d7c4e3264252dae891921126c674
Delegated to: Netdev Maintainers
Headers show
Series lan78xx: select CRC32 | expand

Checks

Context Check Description
netdev/cover_letter success Single patches do not need cover letters
netdev/fixes_present success Fixes tag not required for -next series
netdev/patch_count success Link
netdev/tree_selection success Guessed tree name to be net-next
netdev/subject_prefix warning Target tree name not specified in the subject
netdev/cc_maintainers fail 1 blamed authors not CCed: Woojung.Huh@microchip.com; 15 maintainers not CCed: andrii@kernel.org hayeswang@realtek.com daniel@iogearbox.net andrew@lunn.ch linux@rempel-privat.de songliubraving@fb.com bpf@vger.kernel.org juerg.haefliger@canonical.com yhs@fb.com Woojung.Huh@microchip.com kafai@fb.com geert+renesas@glider.be john.fastabend@gmail.com ast@kernel.org kpsingh@kernel.org
netdev/source_inline success Was 0 now: 0
netdev/verify_signedoff success Signed-off-by tag matches author and committer
netdev/module_param success Was 0 now: 0
netdev/build_32bit success Errors and warnings before: 0 this patch: 0
netdev/kdoc success Errors and warnings before: 0 this patch: 0
netdev/verify_fixes success Fixes tag looks correct
netdev/checkpatch success total: 0 errors, 0 warnings, 0 checks, 7 lines checked
netdev/build_allmodconfig_warn success Errors and warnings before: 0 this patch: 0
netdev/header_inline success No static functions without inline keyword in header files

Commit Message

Vegard Nossum Oct. 15, 2021, 1:07 p.m. UTC
Fix the following build/link error by adding a dependency on the CRC32
routines:

  ld: drivers/net/usb/lan78xx.o: in function `lan78xx_set_multicast':
  lan78xx.c:(.text+0x48cf): undefined reference to `crc32_le'

The actual use of crc32_le() comes indirectly through ether_crc().

Fixes: 55d7de9de6c30 ("Microchip's LAN7800 family USB 2/3 to 10/100/1000 Ethernet device driver")
Signed-off-by: Vegard Nossum <vegard.nossum@oracle.com>
---
 drivers/net/usb/Kconfig | 1 +
 1 file changed, 1 insertion(+)

Comments

patchwork-bot+netdevbpf@kernel.org Oct. 15, 2021, 1:40 p.m. UTC | #1
Hello:

This patch was applied to netdev/net.git (master)
by David S. Miller <davem@davemloft.net>:

On Fri, 15 Oct 2021 15:07:54 +0200 you wrote:
> Fix the following build/link error by adding a dependency on the CRC32
> routines:
> 
>   ld: drivers/net/usb/lan78xx.o: in function `lan78xx_set_multicast':
>   lan78xx.c:(.text+0x48cf): undefined reference to `crc32_le'
> 
> The actual use of crc32_le() comes indirectly through ether_crc().
> 
> [...]

Here is the summary with links:
  - lan78xx: select CRC32
    https://git.kernel.org/netdev/net/c/46393d61a328

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
diff mbox series

Patch

diff --git a/drivers/net/usb/Kconfig b/drivers/net/usb/Kconfig
index f87f175033731..b554054a7560a 100644
--- a/drivers/net/usb/Kconfig
+++ b/drivers/net/usb/Kconfig
@@ -117,6 +117,7 @@  config USB_LAN78XX
 	select PHYLIB
 	select MICROCHIP_PHY
 	select FIXED_PHY
+	select CRC32
 	help
 	  This option adds support for Microchip LAN78XX based USB 2
 	  & USB 3 10/100/1000 Ethernet adapters.