| Message ID | 20211018091758.858899-1-luo.penghao@zte.com.cn (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [linux-next] xfrm: Remove redundant fields | expand |
| Context | Check | Description |
|---|---|---|
| netdev/cover_letter | success | Single patches do not need cover letters |
| netdev/fixes_present | success | Fixes tag not required for -next series |
| netdev/patch_count | success | Link |
| netdev/tree_selection | success | Guessed tree name to be net-next |
| netdev/subject_prefix | warning | Target tree name not specified in the subject |
| netdev/cc_maintainers | success | CCed 5 of 5 maintainers |
| netdev/source_inline | success | Was 0 now: 0 |
| netdev/verify_signedoff | success | Signed-off-by tag matches author and committer |
| netdev/module_param | success | Was 0 now: 0 |
| netdev/build_32bit | fail | Errors and warnings before: 8 this patch: 8 |
| netdev/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| netdev/verify_fixes | success | No Fixes tag |
| netdev/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 16 lines checked |
| netdev/build_allmodconfig_warn | success | Errors and warnings before: 4 this patch: 4 |
| netdev/header_inline | success | No static functions without inline keyword in header files |
On Mon, Oct 18, 2021 at 09:17:58AM +0000, luo penghao wrote: > From: penghao luo <luo.penghao@zte.com.cn> > > the variable err is not necessary in such places. It should be revmoved > for the simplicity of the code. > > The clang_analyzer complains as follows: > > net/xfrm/xfrm_input.c:530: warning: > > Although the value stored to 'err' is used in the enclosing expression, > the value is never actually read from 'err'. > > Reported-by: Zeal Robot <zealci@zte.com.cn> > Signed-off-by: penghao luo <luo.penghao@zte.com.cn> > --- > net/xfrm/xfrm_input.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/net/xfrm/xfrm_input.c b/net/xfrm/xfrm_input.c > index 3df0861..ff34667 100644 > --- a/net/xfrm/xfrm_input.c > +++ b/net/xfrm/xfrm_input.c > @@ -530,7 +530,7 @@ int xfrm_input(struct sk_buff *skb, int nexthdr, __be32 spi, int encap_type) > goto drop; > } > > - if ((err = xfrm_parse_spi(skb, nexthdr, &spi, &seq)) != 0) { > + if ((xfrm_parse_spi(skb, nexthdr, &spi, &seq)) != 0) { I agree that assigning the value to err is not needed. But you may also wish to consider: 1. Dropping the () around the call to xfrm_parse_spi, which seem out of place now. 2. Dropping the explicit check against zero Which would leave you with: if (xfrm_parse_spi(skb, nexthdr, &spi, &seq)) { > XFRM_INC_STATS(net, LINUX_MIB_XFRMINHDRERROR); > goto drop; > } > @@ -560,7 +560,7 @@ int xfrm_input(struct sk_buff *skb, int nexthdr, __be32 spi, int encap_type) > } > > seq = 0; > - if (!spi && (err = xfrm_parse_spi(skb, nexthdr, &spi, &seq)) != 0) { > + if (!spi && (xfrm_parse_spi(skb, nexthdr, &spi, &seq)) != 0) { > secpath_reset(skb); > XFRM_INC_STATS(net, LINUX_MIB_XFRMINHDRERROR); > goto drop; > -- > 2.15.2 > >
diff --git a/net/xfrm/xfrm_input.c b/net/xfrm/xfrm_input.c index 3df0861..ff34667 100644 --- a/net/xfrm/xfrm_input.c +++ b/net/xfrm/xfrm_input.c @@ -530,7 +530,7 @@ int xfrm_input(struct sk_buff *skb, int nexthdr, __be32 spi, int encap_type) goto drop; } - if ((err = xfrm_parse_spi(skb, nexthdr, &spi, &seq)) != 0) { + if ((xfrm_parse_spi(skb, nexthdr, &spi, &seq)) != 0) { XFRM_INC_STATS(net, LINUX_MIB_XFRMINHDRERROR); goto drop; } @@ -560,7 +560,7 @@ int xfrm_input(struct sk_buff *skb, int nexthdr, __be32 spi, int encap_type) } seq = 0; - if (!spi && (err = xfrm_parse_spi(skb, nexthdr, &spi, &seq)) != 0) { + if (!spi && (xfrm_parse_spi(skb, nexthdr, &spi, &seq)) != 0) { secpath_reset(skb); XFRM_INC_STATS(net, LINUX_MIB_XFRMINHDRERROR); goto drop;