| Message ID | 20211021065019.1047768-1-luo.penghao@zte.com.cn (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [linux-next] octeontx2-af: Remove redundant assignment operations | expand |
On Thu, 21 Oct 2021 06:50:19 +0000 luo penghao wrote: > The variable err will be reassigned on subsequent branches, and this > assignment does not perform related value operations. > > clang_analyzer complains as follows: > > drivers/net/ethernet/marvell/sky2.c:4988: warning: > > Although the value stored to 'err' is used in the enclosing expression, > the value is never actually read from 'err'. Oh you did CC Mirko on this version.. Do you not have the CCs automated? scripts/get_maintainer.pl is your friend. If you're posting a new version of the patch please put [PATCH v2] as the subject prefix. And stop putting the pointless linux-next there. Thanks.
diff --git a/drivers/net/ethernet/marvell/sky2.c b/drivers/net/ethernet/marvell/sky2.c index 8b8bff5..33558aa 100644 --- a/drivers/net/ethernet/marvell/sky2.c +++ b/drivers/net/ethernet/marvell/sky2.c @@ -4985,7 +4985,7 @@ static int sky2_probe(struct pci_dev *pdev, const struct pci_device_id *ent) pci_set_master(pdev); if (sizeof(dma_addr_t) > sizeof(u32) && - !(err = dma_set_mask(&pdev->dev, DMA_BIT_MASK(64)))) { + !dma_set_mask(&pdev->dev, DMA_BIT_MASK(64))) { using_dac = 1; err = dma_set_coherent_mask(&pdev->dev, DMA_BIT_MASK(64)); if (err < 0) {
The variable err will be reassigned on subsequent branches, and this assignment does not perform related value operations. clang_analyzer complains as follows: drivers/net/ethernet/marvell/sky2.c:4988: warning: Although the value stored to 'err' is used in the enclosing expression, the value is never actually read from 'err'. Reported-by: Zeal Robot <zealci@zte.com.cn> Signed-off-by: luo penghao <luo.penghao@zte.com.cn> --- drivers/net/ethernet/marvell/sky2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)