| Message ID | 20211026092239.208781-1-colin.i.king@gmail.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [next] gve: Fix spelling mistake "droping" -> "dropping" | expand |
10/26/21 12:22 PM, Colin Ian King пишет: > There is a spelling mistake in a netdev_warn message. Fix it. > > Signed-off-by: Colin Ian King <colin.i.king@gmail.com> you could fix the second instance as well: grep -nri droping drivers/net/ drivers/net/wireless/mac80211_hwsim.c:1279: /* Droping until WARN_QUEUE level */ drivers/net/ethernet/google/gve/gve_rx.c:441: "RX fragment error: packet_buffer_size=%d, frag_size=%d, droping packet.", > --- > drivers/net/ethernet/google/gve/gve_rx.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/google/gve/gve_rx.c b/drivers/net/ethernet/google/gve/gve_rx.c > index c8500babbd1d..ef4aa6487c55 100644 > --- a/drivers/net/ethernet/google/gve/gve_rx.c > +++ b/drivers/net/ethernet/google/gve/gve_rx.c > @@ -438,7 +438,7 @@ static bool gve_rx_ctx_init(struct gve_rx_ctx *ctx, struct gve_rx_ring *rx) > if (frag_size > rx->packet_buffer_size) { > packet_size_error = true; > netdev_warn(priv->dev, > - "RX fragment error: packet_buffer_size=%d, frag_size=%d, droping packet.", > + "RX fragment error: packet_buffer_size=%d, frag_size=%d, dropping packet.", > rx->packet_buffer_size, be16_to_cpu(desc->len)); > } > page_info = &rx->data.page_info[idx]; >
On 26/10/2021 10:32, Denis Kirjanov wrote: > > > 10/26/21 12:22 PM, Colin Ian King пишет: >> There is a spelling mistake in a netdev_warn message. Fix it. >> >> Signed-off-by: Colin Ian King <colin.i.king@gmail.com> > > you could fix the second instance as well: Will do. Thanks for noting that :-) > > grep -nri droping drivers/net/ > drivers/net/wireless/mac80211_hwsim.c:1279: /* Droping until > WARN_QUEUE level */ > drivers/net/ethernet/google/gve/gve_rx.c:441: "RX > fragment error: packet_buffer_size=%d, frag_size=%d, droping packet.", > > >> --- >> drivers/net/ethernet/google/gve/gve_rx.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/net/ethernet/google/gve/gve_rx.c >> b/drivers/net/ethernet/google/gve/gve_rx.c >> index c8500babbd1d..ef4aa6487c55 100644 >> --- a/drivers/net/ethernet/google/gve/gve_rx.c >> +++ b/drivers/net/ethernet/google/gve/gve_rx.c >> @@ -438,7 +438,7 @@ static bool gve_rx_ctx_init(struct gve_rx_ctx >> *ctx, struct gve_rx_ring *rx) >> if (frag_size > rx->packet_buffer_size) { >> packet_size_error = true; >> netdev_warn(priv->dev, >> - "RX fragment error: packet_buffer_size=%d, >> frag_size=%d, droping packet.", >> + "RX fragment error: packet_buffer_size=%d, >> frag_size=%d, dropping packet.", >> rx->packet_buffer_size, be16_to_cpu(desc->len)); >> } >> page_info = &rx->data.page_info[idx]; >>
diff --git a/drivers/net/ethernet/google/gve/gve_rx.c b/drivers/net/ethernet/google/gve/gve_rx.c index c8500babbd1d..ef4aa6487c55 100644 --- a/drivers/net/ethernet/google/gve/gve_rx.c +++ b/drivers/net/ethernet/google/gve/gve_rx.c @@ -438,7 +438,7 @@ static bool gve_rx_ctx_init(struct gve_rx_ctx *ctx, struct gve_rx_ring *rx) if (frag_size > rx->packet_buffer_size) { packet_size_error = true; netdev_warn(priv->dev, - "RX fragment error: packet_buffer_size=%d, frag_size=%d, droping packet.", + "RX fragment error: packet_buffer_size=%d, frag_size=%d, dropping packet.", rx->packet_buffer_size, be16_to_cpu(desc->len)); } page_info = &rx->data.page_info[idx];
There is a spelling mistake in a netdev_warn message. Fix it. Signed-off-by: Colin Ian King <colin.i.king@gmail.com> --- drivers/net/ethernet/google/gve/gve_rx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)