| Message ID | 20211026215031.5157-1-dongli.zhang@oracle.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 9159f102402a64ac85e676b75cc1f9c62c5b4b73 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [1/1] vmxnet3: do not stop tx queues after netif_device_detach() | expand |
| Context | Check | Description |
|---|---|---|
| netdev/cover_letter | success | Single patches do not need cover letters |
| netdev/fixes_present | success | Fixes tag not required for -next series |
| netdev/patch_count | success | Link |
| netdev/tree_selection | success | Guessed tree name to be net-next |
| netdev/subject_prefix | warning | Target tree name not specified in the subject |
| netdev/cc_maintainers | success | CCed 5 of 5 maintainers |
| netdev/source_inline | success | Was 0 now: 0 |
| netdev/verify_signedoff | success | Signed-off-by tag matches author and committer |
| netdev/module_param | success | Was 0 now: 0 |
| netdev/build_32bit | success | Errors and warnings before: 14 this patch: 14 |
| netdev/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| netdev/verify_fixes | success | No Fixes tag |
| netdev/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 7 lines checked |
| netdev/build_allmodconfig_warn | success | Errors and warnings before: 14 this patch: 14 |
| netdev/header_inline | success | No static functions without inline keyword in header files |
Hello: This patch was applied to netdev/net.git (master) by David S. Miller <davem@davemloft.net>: On Tue, 26 Oct 2021 14:50:31 -0700 you wrote: > The netif_device_detach() conditionally stops all tx queues if the queues > are running. There is no need to call netif_tx_stop_all_queues() again. > > Signed-off-by: Dongli Zhang <dongli.zhang@oracle.com> > --- > While I do not have vmware env, I did test with QEMU + vmxnet3. > > [...] Here is the summary with links: - [1/1] vmxnet3: do not stop tx queues after netif_device_detach() https://git.kernel.org/netdev/net/c/9159f102402a You are awesome, thank you!
diff --git a/drivers/net/vmxnet3/vmxnet3_drv.c b/drivers/net/vmxnet3/vmxnet3_drv.c index 142f70670f5c..8799854bacb2 100644 --- a/drivers/net/vmxnet3/vmxnet3_drv.c +++ b/drivers/net/vmxnet3/vmxnet3_drv.c @@ -3833,7 +3833,6 @@ vmxnet3_suspend(struct device *device) vmxnet3_free_intr_resources(adapter); netif_device_detach(netdev); - netif_tx_stop_all_queues(netdev); /* Create wake-up filters. */ pmConf = adapter->pm_conf;
The netif_device_detach() conditionally stops all tx queues if the queues are running. There is no need to call netif_tx_stop_all_queues() again. Signed-off-by: Dongli Zhang <dongli.zhang@oracle.com> --- While I do not have vmware env, I did test with QEMU + vmxnet3. drivers/net/vmxnet3/vmxnet3_drv.c | 1 - 1 file changed, 1 deletion(-)