| Message ID | 20211029220316.2003519-2-sukadev@linux.ibm.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 6e20d00158f31f7631d68b86996b7e951c4451c8 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net,1/3] ibmvnic: don't stop queue in xmit | expand |
On 2021-10-29 15:03, Sukadev Bhattiprolu wrote: > Soon after registering a CRQ it is possible that we get a fail over or > maybe a CRQ_INIT from the VIOS while interrupts were disabled. > > Look for any such CRQs after enabling interrupts. > > Otherwise we can intermittently fail to bring up ibmvnic adapters > during > boot, specially in kexec/kdump kernels. > > Fixes: 032c5e82847a ("Driver for IBM System i/p VNIC protocol") > Reported-by: Vaishnavi Bhat <vaish123@in.ibm.com> > Signed-off-by: Sukadev Bhattiprolu <sukadev@linux.ibm.com> Reviewed-by: Dany Madden <drt@linux.ibm.com>
diff --git a/drivers/net/ethernet/ibm/ibmvnic.c b/drivers/net/ethernet/ibm/ibmvnic.c index a1533979c670..50956f622b11 100644 --- a/drivers/net/ethernet/ibm/ibmvnic.c +++ b/drivers/net/ethernet/ibm/ibmvnic.c @@ -5611,6 +5611,9 @@ static int init_crq_queue(struct ibmvnic_adapter *adapter) crq->cur = 0; spin_lock_init(&crq->lock); + /* process any CRQs that were queued before we enabled interrupts */ + tasklet_schedule(&adapter->tasklet); + return retrc; req_irq_failed:
Soon after registering a CRQ it is possible that we get a fail over or maybe a CRQ_INIT from the VIOS while interrupts were disabled. Look for any such CRQs after enabling interrupts. Otherwise we can intermittently fail to bring up ibmvnic adapters during boot, specially in kexec/kdump kernels. Fixes: 032c5e82847a ("Driver for IBM System i/p VNIC protocol") Reported-by: Vaishnavi Bhat <vaish123@in.ibm.com> Signed-off-by: Sukadev Bhattiprolu <sukadev@linux.ibm.com> --- drivers/net/ethernet/ibm/ibmvnic.c | 3 +++ 1 file changed, 3 insertions(+)