| Message ID | 20211103054113.2130582-1-andrii@kernel.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 401a33da3a45cc05859b121314f8ab52c2c01977 |
| Delegated to: | BPF |
| Headers | show |
| Series | [bpf-next] selftests/bpf: make netcnt selftests serial to avoid spurious failures | expand |
Hello: This patch was applied to bpf/bpf.git (master) by Daniel Borkmann <daniel@iogearbox.net>: On Tue, 2 Nov 2021 22:41:13 -0700 you wrote: > When running `./test_progs -j` test_netcnt fails with a very high > probability, undercounting number of packets received (9999 vs expected > 10000). It seems to be conflicting with other cgroup/skb selftests. So > make it serial for now to make parallel mode more robust. > > Signed-off-by: Andrii Nakryiko <andrii@kernel.org> > > [...] Here is the summary with links: - [bpf-next] selftests/bpf: make netcnt selftests serial to avoid spurious failures https://git.kernel.org/bpf/bpf/c/401a33da3a45 You are awesome, thank you!
diff --git a/tools/testing/selftests/bpf/prog_tests/netcnt.c b/tools/testing/selftests/bpf/prog_tests/netcnt.c index 6ede48bde91b..954964f0ac3d 100644 --- a/tools/testing/selftests/bpf/prog_tests/netcnt.c +++ b/tools/testing/selftests/bpf/prog_tests/netcnt.c @@ -8,7 +8,7 @@ #define CG_NAME "/netcnt" -void test_netcnt(void) +void serial_test_netcnt(void) { union percpu_net_cnt *percpu_netcnt = NULL; struct bpf_cgroup_storage_key key;
When running `./test_progs -j` test_netcnt fails with a very high probability, undercounting number of packets received (9999 vs expected 10000). It seems to be conflicting with other cgroup/skb selftests. So make it serial for now to make parallel mode more robust. Signed-off-by: Andrii Nakryiko <andrii@kernel.org> --- tools/testing/selftests/bpf/prog_tests/netcnt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)