| Message ID | 20211104171747.10509-1-kabel@kernel.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | dc2fc9f03c5c410d8f01c2206b3d529f80b13733 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net] net: dsa: mv88e6xxx: Don't support >1G speeds on 6191X on ports other than 10 | expand |
On Thu, Nov 04, 2021 at 06:17:47PM +0100, Marek Behún wrote: > Model 88E6191X only supports >1G speeds on port 10. Port 0 and 9 are > only 1G. Interesting. The original commit says: SERDESes can do USXGMII, 10GBASER and 5GBASER (on 6191X only one SERDES is capable of more than 1g; USXGMII is not yet supported with this change) which is ambiguously worded - so I guess we now know that it's only port 10 that supports speeds above 1G. Can ports 0 / 1 / 10 be changed at runtime (iow, is the C_Mode field writable on these ports?) Thanks.
On Thu, 4 Nov 2021 18:15:57 +0000 "Russell King (Oracle)" <linux@armlinux.org.uk> wrote: > On Thu, Nov 04, 2021 at 06:17:47PM +0100, Marek Behún wrote: > > Model 88E6191X only supports >1G speeds on port 10. Port 0 and 9 are > > only 1G. > > Interesting. The original commit says: > > SERDESes can do USXGMII, 10GBASER and 5GBASER (on 6191X only one > SERDES is capable of more than 1g; USXGMII is not yet supported > with this change) > > which is ambiguously worded - so I guess we now know that it's only > port 10 that supports speeds above 1G. Yes, I just found this info in datasheet. > Can ports 0 / 1 / 10 be changed at runtime (iow, is the C_Mode field > writable on these ports?) Yes, cmode is writable on these ports. serdes.c also provides some errata fixes when changing cmode. (BTW Russell I have already updated your patch net: dsa: mv88e6xxx: populate supported_interfaces from your net-queue branch. I am rebasing your work on top of net-next and also adding some other stuff. I will send you the patches later.) Marek
On Thu, Nov 04, 2021 at 06:17:47PM +0100, Marek Behún wrote: > Model 88E6191X only supports >1G speeds on port 10. Port 0 and 9 are > only 1G. > > Fixes: de776d0d316f ("net: dsa: mv88e6xxx: add support for mv88e6393x family") > Signed-off-by: Marek Behún <kabel@kernel.org> > Cc: Russell King (Oracle) <rmk+kernel@armlinux.org.uk> Reviewed-by: Andrew Lunn <andrew@lunn.ch> Andrew
Hello: This patch was applied to netdev/net.git (master) by Jakub Kicinski <kuba@kernel.org>: On Thu, 4 Nov 2021 18:17:47 +0100 you wrote: > Model 88E6191X only supports >1G speeds on port 10. Port 0 and 9 are > only 1G. > > Fixes: de776d0d316f ("net: dsa: mv88e6xxx: add support for mv88e6393x family") > Signed-off-by: Marek Behún <kabel@kernel.org> > Cc: Russell King (Oracle) <rmk+kernel@armlinux.org.uk> > > [...] Here is the summary with links: - [net] net: dsa: mv88e6xxx: Don't support >1G speeds on 6191X on ports other than 10 https://git.kernel.org/netdev/net/c/dc2fc9f03c5c You are awesome, thank you!
diff --git a/drivers/net/dsa/mv88e6xxx/chip.c b/drivers/net/dsa/mv88e6xxx/chip.c index 14c678a9e41b..f00cbf5753b9 100644 --- a/drivers/net/dsa/mv88e6xxx/chip.c +++ b/drivers/net/dsa/mv88e6xxx/chip.c @@ -640,7 +640,10 @@ static void mv88e6393x_phylink_validate(struct mv88e6xxx_chip *chip, int port, unsigned long *mask, struct phylink_link_state *state) { - if (port == 0 || port == 9 || port == 10) { + bool is_6191x = + chip->info->prod_num == MV88E6XXX_PORT_SWITCH_ID_PROD_6191X; + + if (((port == 0 || port == 9) && !is_6191x) || port == 10) { phylink_set(mask, 10000baseT_Full); phylink_set(mask, 10000baseKR_Full); phylink_set(mask, 10000baseCR_Full);
Model 88E6191X only supports >1G speeds on port 10. Port 0 and 9 are only 1G. Fixes: de776d0d316f ("net: dsa: mv88e6xxx: add support for mv88e6393x family") Signed-off-by: Marek Behún <kabel@kernel.org> Cc: Russell King (Oracle) <rmk+kernel@armlinux.org.uk> --- drivers/net/dsa/mv88e6xxx/chip.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)