| Message ID | 20211110081109.GG5176@kili (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 721111b1b29c67fd18ac2f69b3a48c06ba996762 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net-next] gve: fix unmatched u64_stats_update_end() | expand |
Hello: This patch was applied to netdev/net.git (master) by David S. Miller <davem@davemloft.net>: On Wed, 10 Nov 2021 11:11:09 +0300 you wrote: > The u64_stats_update_end() call is supposed to be inside the curly > braces so it pairs with the u64_stats_update_begin(). > > Fixes: 37149e9374bf ("gve: Implement packet continuation for RX.") > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> > --- > Based on the indenting. Not tested. > > [...] Here is the summary with links: - [net-next] gve: fix unmatched u64_stats_update_end() https://git.kernel.org/netdev/net/c/721111b1b29c You are awesome, thank you!
diff --git a/drivers/net/ethernet/google/gve/gve_rx.c b/drivers/net/ethernet/google/gve/gve_rx.c index c8500babbd1d..3d04b5aff331 100644 --- a/drivers/net/ethernet/google/gve/gve_rx.c +++ b/drivers/net/ethernet/google/gve/gve_rx.c @@ -500,7 +500,8 @@ static struct sk_buff *gve_rx_skb(struct gve_priv *priv, struct gve_rx_ring *rx, rx->rx_copied_pkt++; rx->rx_frag_copy_cnt++; rx->rx_copybreak_pkt++; - } u64_stats_update_end(&rx->statss); + u64_stats_update_end(&rx->statss); + } } else { if (rx->data.raw_addressing) { int recycle = gve_rx_can_recycle_buffer(page_info);
The u64_stats_update_end() call is supposed to be inside the curly braces so it pairs with the u64_stats_update_begin(). Fixes: 37149e9374bf ("gve: Implement packet continuation for RX.") Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> --- Based on the indenting. Not tested. drivers/net/ethernet/google/gve/gve_rx.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)