Message ID | 20211115070423.6845-1-Meng.Li@windriver.com (mailing list archive) |
---|---|
State | Accepted |
Commit | 9119570039481d56350af1c636f040fb300b8cf3 |
Delegated to: | Netdev Maintainers |
Headers | show |
Series | [v3] net: stmmac: socfpga: add runtime suspend/resume callback for stratix10 platform | expand |
Hello: This patch was applied to netdev/net.git (master) by David S. Miller <davem@davemloft.net>: On Mon, 15 Nov 2021 15:04:23 +0800 you wrote: > From: Meng Li <meng.li@windriver.com> > > According to upstream commit 5ec55823438e("net: stmmac: > add clocks management for gmac driver"), it improve clocks > management for stmmac driver. So, it is necessary to implement > the runtime callback in dwmac-socfpga driver because it doesn't > use the common stmmac_pltfr_pm_ops instance. Otherwise, clocks > are not disabled when system enters suspend status. > > [...] Here is the summary with links: - [v3] net: stmmac: socfpga: add runtime suspend/resume callback for stratix10 platform https://git.kernel.org/netdev/net/c/911957003948 You are awesome, thank you!
diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c index 85208128f135..e478a4017caa 100644 --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c @@ -485,8 +485,28 @@ static int socfpga_dwmac_resume(struct device *dev) } #endif /* CONFIG_PM_SLEEP */ -static SIMPLE_DEV_PM_OPS(socfpga_dwmac_pm_ops, stmmac_suspend, - socfpga_dwmac_resume); +static int __maybe_unused socfpga_dwmac_runtime_suspend(struct device *dev) +{ + struct net_device *ndev = dev_get_drvdata(dev); + struct stmmac_priv *priv = netdev_priv(ndev); + + stmmac_bus_clks_config(priv, false); + + return 0; +} + +static int __maybe_unused socfpga_dwmac_runtime_resume(struct device *dev) +{ + struct net_device *ndev = dev_get_drvdata(dev); + struct stmmac_priv *priv = netdev_priv(ndev); + + return stmmac_bus_clks_config(priv, true); +} + +static const struct dev_pm_ops socfpga_dwmac_pm_ops = { + SET_SYSTEM_SLEEP_PM_OPS(stmmac_suspend, socfpga_dwmac_resume) + SET_RUNTIME_PM_OPS(socfpga_dwmac_runtime_suspend, socfpga_dwmac_runtime_resume, NULL) +}; static const struct socfpga_dwmac_ops socfpga_gen5_ops = { .set_phy_mode = socfpga_gen5_set_phy_mode,