| Message ID | 20211124084048.175456-1-yangyingliang@huawei.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 739752d655b3a5fa6ea3d72c1b53cec082f86486 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [-next] tsnep: Add missing of_node_put() in tsnep_mdio_init() | expand |
Hello: This patch was applied to netdev/net-next.git (master) by Jakub Kicinski <kuba@kernel.org>: On Wed, 24 Nov 2021 16:40:48 +0800 you wrote: > The node pointer is returned by of_get_child_by_name() with > refcount incremented in tsnep_mdio_init(). Calling of_node_put() > to aovid the refcount leak in tsnep_mdio_init(). > > Reported-by: Hulk Robot <hulkci@huawei.com> > Signed-off-by: Yang Yingliang <yangyingliang@huawei.com> > > [...] Here is the summary with links: - [-next] tsnep: Add missing of_node_put() in tsnep_mdio_init() https://git.kernel.org/netdev/net-next/c/739752d655b3 You are awesome, thank you!
diff --git a/drivers/net/ethernet/engleder/tsnep_main.c b/drivers/net/ethernet/engleder/tsnep_main.c index 8333313dd706..d7d436d6aed2 100644 --- a/drivers/net/ethernet/engleder/tsnep_main.c +++ b/drivers/net/ethernet/engleder/tsnep_main.c @@ -1089,9 +1089,10 @@ static int tsnep_mdio_init(struct tsnep_adapter *adapter) adapter->mdiobus->phy_mask = 0x0000001; retval = of_mdiobus_register(adapter->mdiobus, np); + +out: if (np) of_node_put(np); -out: return retval; }
The node pointer is returned by of_get_child_by_name() with refcount incremented in tsnep_mdio_init(). Calling of_node_put() to aovid the refcount leak in tsnep_mdio_init(). Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com> --- drivers/net/ethernet/engleder/tsnep_main.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)