| Message ID | 20211125141457.716921-1-cascardo@canonical.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | c26381f97e2a7df43826150dc7d4c207bd6794a5 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | nfc: virtual_ncidev: change default device permissions | expand |
On 25/11/2021 15:14, Thadeu Lima de Souza Cascardo wrote: > Device permissions is S_IALLUGO, with many unnecessary bits. Remove them > and also remove read and write permissions from group and others. > > Before the change: > crwsrwsrwt 1 0 0 10, 125 Nov 25 13:59 /dev/virtual_nci > > After the change: > crw------- 1 0 0 10, 125 Nov 25 14:05 /dev/virtual_nci > > Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@canonical.com> > --- > drivers/nfc/virtual_ncidev.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> Best regards, Krzysztof
On 25/11/2021 15:14, Thadeu Lima de Souza Cascardo wrote: > Device permissions is S_IALLUGO, with many unnecessary bits. Remove them > and also remove read and write permissions from group and others. > > Before the change: > crwsrwsrwt 1 0 0 10, 125 Nov 25 13:59 /dev/virtual_nci > > After the change: > crw------- 1 0 0 10, 125 Nov 25 14:05 /dev/virtual_nci > > Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@canonical.com> > --- > drivers/nfc/virtual_ncidev.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/nfc/virtual_ncidev.c b/drivers/nfc/virtual_ncidev.c > index 221fa3bb8705..f577449e4935 100644 --- a/drivers/nfc/virtual_ncidev.c > +++ b/drivers/nfc/virtual_ncidev.c > @@ -202,7 +202,7 @@ static int __init virtual_ncidev_init(void) > miscdev.minor = MISC_DYNAMIC_MINOR; > miscdev.name = "virtual_nci"; > miscdev.fops = &virtual_ncidev_fops; > - miscdev.mode = S_IALLUGO; > + miscdev.mode = 0600; > > return misc_register(&miscdev); > } > -- Reviewed-by: Bongsu Jeon <bongsu.jeon@samsung.com> Thanks.
Hello: This patch was applied to netdev/net.git (master) by Jakub Kicinski <kuba@kernel.org>: On Thu, 25 Nov 2021 11:14:57 -0300 you wrote: > Device permissions is S_IALLUGO, with many unnecessary bits. Remove them > and also remove read and write permissions from group and others. > > Before the change: > crwsrwsrwt 1 0 0 10, 125 Nov 25 13:59 /dev/virtual_nci > > After the change: > crw------- 1 0 0 10, 125 Nov 25 14:05 /dev/virtual_nci > > [...] Here is the summary with links: - nfc: virtual_ncidev: change default device permissions https://git.kernel.org/netdev/net/c/c26381f97e2a You are awesome, thank you!
diff --git a/drivers/nfc/virtual_ncidev.c b/drivers/nfc/virtual_ncidev.c index 221fa3bb8705..f577449e4935 100644 --- a/drivers/nfc/virtual_ncidev.c +++ b/drivers/nfc/virtual_ncidev.c @@ -202,7 +202,7 @@ static int __init virtual_ncidev_init(void) miscdev.minor = MISC_DYNAMIC_MINOR; miscdev.name = "virtual_nci"; miscdev.fops = &virtual_ncidev_fops; - miscdev.mode = S_IALLUGO; + miscdev.mode = 0600; return misc_register(&miscdev); }
Device permissions is S_IALLUGO, with many unnecessary bits. Remove them and also remove read and write permissions from group and others. Before the change: crwsrwsrwt 1 0 0 10, 125 Nov 25 13:59 /dev/virtual_nci After the change: crw------- 1 0 0 10, 125 Nov 25 14:05 /dev/virtual_nci Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@canonical.com> --- drivers/nfc/virtual_ncidev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)