| Message ID | 20211129021652.3220400-1-jk@codeconstruct.com.au (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | d8519565447078f141c58ba4193d820f2cdf1914 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net] mctp: test: fix skb free in test device tx | expand |
Hello: This patch was applied to netdev/net.git (master) by David S. Miller <davem@davemloft.net>: On Mon, 29 Nov 2021 10:16:52 +0800 you wrote: > In our test device, we're currently freeing skbs in the transmit path > with kfree(), rather than kfree_skb(). This change uses the correct > kfree_skb() instead. > > Fixes: ded21b722995 ("mctp: Add test utils") > Reported-by: kernel test robot <lkp@intel.com> > Reported-by: Dan Carpenter <dan.carpenter@oracle.com> > Signed-off-by: Jeremy Kerr <jk@codeconstruct.com.au> > > [...] Here is the summary with links: - [net] mctp: test: fix skb free in test device tx https://git.kernel.org/netdev/net/c/d85195654470 You are awesome, thank you!
diff --git a/net/mctp/test/utils.c b/net/mctp/test/utils.c index cc6b8803aa9d..7b7918702592 100644 --- a/net/mctp/test/utils.c +++ b/net/mctp/test/utils.c @@ -12,7 +12,7 @@ static netdev_tx_t mctp_test_dev_tx(struct sk_buff *skb, struct net_device *ndev) { - kfree(skb); + kfree_skb(skb); return NETDEV_TX_OK; }
In our test device, we're currently freeing skbs in the transmit path with kfree(), rather than kfree_skb(). This change uses the correct kfree_skb() instead. Fixes: ded21b722995 ("mctp: Add test utils") Reported-by: kernel test robot <lkp@intel.com> Reported-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Jeremy Kerr <jk@codeconstruct.com.au> --- net/mctp/test/utils.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)