| Message ID | 20211129095850.2018071-1-ivecera@redhat.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 754d71be52926563ddd5cef2a3837a5742a08c37 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net-next] selftests: net: bridge: fix typo in vlan_filtering dependency test | expand |
On 29/11/2021 11:58, Ivan Vecera wrote: > Prior patch: > ]# TESTS=vlmc_filtering_test ./bridge_vlan_mcast.sh > TEST: Vlan multicast snooping enable [ OK ] > Device "bridge" does not exist. > TEST: Disable multicast vlan snooping when vlan filtering is disabled [FAIL] > Vlan filtering is disabled but multicast vlan snooping is still enabled > > After patch: > # TESTS=vlmc_filtering_test ./bridge_vlan_mcast.sh > TEST: Vlan multicast snooping enable [ OK ] > TEST: Disable multicast vlan snooping when vlan filtering is disabled [ OK ] > > Fixes: f5a9dd58f48b7c ("selftests: net: bridge: add test for vlan_filtering dependency") > Cc: Nikolay Aleksandrov <nikolay@nvidia.com> > Signed-off-by: Ivan Vecera <ivecera@redhat.com> > --- > tools/testing/selftests/net/forwarding/bridge_vlan_mcast.sh | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/testing/selftests/net/forwarding/bridge_vlan_mcast.sh b/tools/testing/selftests/net/forwarding/bridge_vlan_mcast.sh > index 5224a5a8595b32..8748d1b1d95b71 100755 > --- a/tools/testing/selftests/net/forwarding/bridge_vlan_mcast.sh > +++ b/tools/testing/selftests/net/forwarding/bridge_vlan_mcast.sh > @@ -527,7 +527,7 @@ vlmc_filtering_test() > { > RET=0 > ip link set dev br0 type bridge vlan_filtering 0 > - ip -j -d link show dev bridge | \ > + ip -j -d link show dev br0 | \ > jq -e "select(.[0].linkinfo.info_data.mcast_vlan_snooping == 1)" &>/dev/null > check_fail $? "Vlan filtering is disabled but multicast vlan snooping is still enabled" > log_test "Disable multicast vlan snooping when vlan filtering is disabled" > Good catch, thanks! I've also prepared a few fixes and improvements for the tests, I'll send them out this week. :) Acked-by: Nikolay Aleksandrov <nikolay@nvidia.com>
Hello: This patch was applied to netdev/net-next.git (master) by David S. Miller <davem@davemloft.net>: On Mon, 29 Nov 2021 10:58:50 +0100 you wrote: > Prior patch: > ]# TESTS=vlmc_filtering_test ./bridge_vlan_mcast.sh > TEST: Vlan multicast snooping enable [ OK ] > Device "bridge" does not exist. > TEST: Disable multicast vlan snooping when vlan filtering is disabled [FAIL] > Vlan filtering is disabled but multicast vlan snooping is still enabled > > [...] Here is the summary with links: - [net-next] selftests: net: bridge: fix typo in vlan_filtering dependency test https://git.kernel.org/netdev/net-next/c/754d71be5292 You are awesome, thank you!
diff --git a/tools/testing/selftests/net/forwarding/bridge_vlan_mcast.sh b/tools/testing/selftests/net/forwarding/bridge_vlan_mcast.sh index 5224a5a8595b32..8748d1b1d95b71 100755 --- a/tools/testing/selftests/net/forwarding/bridge_vlan_mcast.sh +++ b/tools/testing/selftests/net/forwarding/bridge_vlan_mcast.sh @@ -527,7 +527,7 @@ vlmc_filtering_test() { RET=0 ip link set dev br0 type bridge vlan_filtering 0 - ip -j -d link show dev bridge | \ + ip -j -d link show dev br0 | \ jq -e "select(.[0].linkinfo.info_data.mcast_vlan_snooping == 1)" &>/dev/null check_fail $? "Vlan filtering is disabled but multicast vlan snooping is still enabled" log_test "Disable multicast vlan snooping when vlan filtering is disabled"
Prior patch: ]# TESTS=vlmc_filtering_test ./bridge_vlan_mcast.sh TEST: Vlan multicast snooping enable [ OK ] Device "bridge" does not exist. TEST: Disable multicast vlan snooping when vlan filtering is disabled [FAIL] Vlan filtering is disabled but multicast vlan snooping is still enabled After patch: # TESTS=vlmc_filtering_test ./bridge_vlan_mcast.sh TEST: Vlan multicast snooping enable [ OK ] TEST: Disable multicast vlan snooping when vlan filtering is disabled [ OK ] Fixes: f5a9dd58f48b7c ("selftests: net: bridge: add test for vlan_filtering dependency") Cc: Nikolay Aleksandrov <nikolay@nvidia.com> Signed-off-by: Ivan Vecera <ivecera@redhat.com> --- tools/testing/selftests/net/forwarding/bridge_vlan_mcast.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)