| Message ID | 20211201111025.13834-1-lizhijian@cn.fujitsu.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [1/3] selftest: net: Correct case name | expand |
On Wed, 1 Dec 2021 19:10:23 +0800 Li Zhijian wrote: > Fixes: 34d0302ab86 ("selftests: Add ipv6 address bind tests to fcnal-test") > Fixes: 75b2b2b3db4 ("selftests: Add ipv4 address bind tests to fcnal-test") Fixes tag: Fixes: 34d0302ab86 ("selftests: Add ipv6 address bind tests to fcnal-test") Has these problem(s): - SHA1 should be at least 12 digits long Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11 or later) just making sure it is not set (or set to "auto"). Fixes tag: Fixes: 75b2b2b3db4 ("selftests: Add ipv4 address bind tests to fcnal-test") Has these problem(s): - SHA1 should be at least 12 digits long Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11 or later) just making sure it is not set (or set to "auto").
On Wed, 1 Dec 2021 19:10:23 +0800 Li Zhijian wrote: > ipv6_addr_bind/ipv4_addr_bind are function name. > > Fixes: 34d0302ab86 ("selftests: Add ipv6 address bind tests to fcnal-test") > Fixes: 75b2b2b3db4 ("selftests: Add ipv4 address bind tests to fcnal-test") > Signed-off-by: Li Zhijian <lizhijian@cn.fujitsu.com> Please send this patch separately from patches 2 and 3. This one is a fix (AFAIU) and needs to be applied to a different tree. Patches 2 and 3 look like improvements / cleanups.
on 2021/12/2 9:54, Jakub Kicinski wrote: > On Wed, 1 Dec 2021 19:10:23 +0800 Li Zhijian wrote: >> ipv6_addr_bind/ipv4_addr_bind are function name. >> >> Fixes: 34d0302ab86 ("selftests: Add ipv6 address bind tests to fcnal-test") >> Fixes: 75b2b2b3db4 ("selftests: Add ipv4 address bind tests to fcnal-test") >> Signed-off-by: Li Zhijian <lizhijian@cn.fujitsu.com> > Please send this patch separately from patches 2 and 3. This one is > a fix (AFAIU) and needs to be applied to a different tree. Patches 2 > and 3 look like improvements / cleanups. > Got it, I will fix it ASAP Thanks Zhijian
diff --git a/tools/testing/selftests/net/fcnal-test.sh b/tools/testing/selftests/net/fcnal-test.sh index 3313566ce906..7f5b265fcb90 100755 --- a/tools/testing/selftests/net/fcnal-test.sh +++ b/tools/testing/selftests/net/fcnal-test.sh @@ -4002,8 +4002,8 @@ EOF ################################################################################ # main -TESTS_IPV4="ipv4_ping ipv4_tcp ipv4_udp ipv4_addr_bind ipv4_runtime ipv4_netfilter" -TESTS_IPV6="ipv6_ping ipv6_tcp ipv6_udp ipv6_addr_bind ipv6_runtime ipv6_netfilter" +TESTS_IPV4="ipv4_ping ipv4_tcp ipv4_udp ipv4_bind ipv4_runtime ipv4_netfilter" +TESTS_IPV6="ipv6_ping ipv6_tcp ipv6_udp ipv6_bind ipv6_runtime ipv6_netfilter" TESTS_OTHER="use_cases" PAUSE_ON_FAIL=no
ipv6_addr_bind/ipv4_addr_bind are function name. Fixes: 34d0302ab86 ("selftests: Add ipv6 address bind tests to fcnal-test") Fixes: 75b2b2b3db4 ("selftests: Add ipv4 address bind tests to fcnal-test") Signed-off-by: Li Zhijian <lizhijian@cn.fujitsu.com> --- tools/testing/selftests/net/fcnal-test.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)