diff mbox series

[net-next,07/11] net: hns3: add void before function which don't receive ret

Message ID 20211203092059.24947-8-huangguangbin2@huawei.com (mailing list archive)
State Accepted
Commit 5ac4f180bd07116c1e57858bc3f6741adbca3eb6
Delegated to: Netdev Maintainers
Headers show
Series net: hns3: some cleanups for -next | expand

Checks

Context Check Description
netdev/tree_selection success Clearly marked for net-next
netdev/fixes_present success Fixes tag not required for -next series
netdev/subject_prefix success Link
netdev/cover_letter success Series has a cover letter
netdev/patch_count success Link
netdev/header_inline success No static functions without inline keyword in header files
netdev/build_32bit success Errors and warnings before: 0 this patch: 0
netdev/cc_maintainers warning 1 maintainers not CCed: leon@kernel.org
netdev/build_clang success Errors and warnings before: 0 this patch: 0
netdev/module_param success Was 0 now: 0
netdev/verify_signedoff success Signed-off-by tag matches author and committer
netdev/verify_fixes success No Fixes tag
netdev/build_allmodconfig_warn success Errors and warnings before: 0 this patch: 0
netdev/checkpatch success total: 0 errors, 0 warnings, 0 checks, 16 lines checked
netdev/kdoc success Errors and warnings before: 0 this patch: 0
netdev/source_inline success Was 0 now: 0

Commit Message

Guangbin Huang Dec. 3, 2021, 9:20 a.m. UTC 
From: Hao Chen <chenhao288@hisilicon.com>

Add void before function which don't receive ret to improve code
readability.

Signed-off-by: Hao Chen <chenhao288@hisilicon.com>
Signed-off-by: Guangbin Huang <huangguangbin2@huawei.com>
---
 drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_devlink.c   | 2 +-
 drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_devlink.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

Comments

Leon Romanovsky Dec. 3, 2021, 11:15 a.m. UTC | #1 
On Fri, Dec 03, 2021 at 05:20:55PM +0800, Guangbin Huang wrote:
> From: Hao Chen <chenhao288@hisilicon.com>
> 
> Add void before function which don't receive ret to improve code
> readability.
> 
> Signed-off-by: Hao Chen <chenhao288@hisilicon.com>
> Signed-off-by: Guangbin Huang <huangguangbin2@huawei.com>
> ---
>  drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_devlink.c   | 2 +-
>  drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_devlink.c | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)

NAK,

Please stop to do it and fix your static analyzer.
https://lore.kernel.org/linux-rdma/20211119172830.GL876299@ziepe.ca/

We don't add (void) in the kernel and especially for the functions that
already declared as void.

   void devlink_register(struct devlink *devlink)

Thanks

> 
> diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_devlink.c b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_devlink.c
> index 4c441e6a5082..9c3199d3c8ee 100644
> --- a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_devlink.c
> +++ b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_devlink.c
> @@ -120,7 +120,7 @@ int hclge_devlink_init(struct hclge_dev *hdev)
>  	hdev->devlink = devlink;
>  
>  	devlink_set_features(devlink, DEVLINK_F_RELOAD);
> -	devlink_register(devlink);
> +	(void)devlink_register(devlink);
>  	return 0;
>  }
>  
> diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_devlink.c b/drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_devlink.c
> index fdc19868b818..75d2926729d3 100644
> --- a/drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_devlink.c
> +++ b/drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_devlink.c
> @@ -122,7 +122,7 @@ int hclgevf_devlink_init(struct hclgevf_dev *hdev)
>  	hdev->devlink = devlink;
>  
>  	devlink_set_features(devlink, DEVLINK_F_RELOAD);
> -	devlink_register(devlink);
> +	(void)devlink_register(devlink);
>  	return 0;
>  }
>  
> -- 
> 2.33.0
>
Guangbin Huang Dec. 3, 2021, 11:27 a.m. UTC | #2 
On 2021/12/3 19:15, Leon Romanovsky wrote:
> On Fri, Dec 03, 2021 at 05:20:55PM +0800, Guangbin Huang wrote:
>> From: Hao Chen <chenhao288@hisilicon.com>
>>
>> Add void before function which don't receive ret to improve code
>> readability.
>>
>> Signed-off-by: Hao Chen <chenhao288@hisilicon.com>
>> Signed-off-by: Guangbin Huang <huangguangbin2@huawei.com>
>> ---
>>   drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_devlink.c   | 2 +-
>>   drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_devlink.c | 2 +-
>>   2 files changed, 2 insertions(+), 2 deletions(-)
> 
> NAK,
> 
> Please stop to do it and fix your static analyzer.
> https://lore.kernel.org/linux-rdma/20211119172830.GL876299@ziepe.ca/
> 
> We don't add (void) in the kernel and especially for the functions that
> already declared as void.
> 
>     void devlink_register(struct devlink *devlink)
> 
> Thanks
> 
Ok, I remove this patch.
Thanks
diff mbox series

Patch

diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_devlink.c b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_devlink.c
index 4c441e6a5082..9c3199d3c8ee 100644
--- a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_devlink.c
+++ b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_devlink.c
@@ -120,7 +120,7 @@  int hclge_devlink_init(struct hclge_dev *hdev)
 	hdev->devlink = devlink;
 
 	devlink_set_features(devlink, DEVLINK_F_RELOAD);
-	devlink_register(devlink);
+	(void)devlink_register(devlink);
 	return 0;
 }
 
diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_devlink.c b/drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_devlink.c
index fdc19868b818..75d2926729d3 100644
--- a/drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_devlink.c
+++ b/drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_devlink.c
@@ -122,7 +122,7 @@  int hclgevf_devlink_init(struct hclgevf_dev *hdev)
 	hdev->devlink = devlink;
 
 	devlink_set_features(devlink, DEVLINK_F_RELOAD);
-	devlink_register(devlink);
+	(void)devlink_register(devlink);
 	return 0;
 }