| Message ID | 20211211172108.74647-1-dsahern@kernel.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 0f108ae4452025fef529671998f6c7f1c4526790 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net] selftests: Fix raw socket bind tests with VRF | expand |
Hello: This patch was applied to netdev/net.git (master) by David S. Miller <davem@davemloft.net>: On Sat, 11 Dec 2021 10:21:08 -0700 you wrote: > Commit referenced below added negative socket bind tests for VRF. The > socket binds should fail since the address to bind to is in a VRF yet > the socket is not bound to the VRF or a device within it. Update the > expected return code to check for 1 (bind failure) so the test passes > when the bind fails as expected. Add a 'show_hint' comment to explain > why the bind is expected to fail. > > [...] Here is the summary with links: - [net] selftests: Fix raw socket bind tests with VRF https://git.kernel.org/netdev/net/c/0f108ae44520 You are awesome, thank you!
diff --git a/tools/testing/selftests/net/fcnal-test.sh b/tools/testing/selftests/net/fcnal-test.sh index d0c45023b4d4..25bba4557a8e 100755 --- a/tools/testing/selftests/net/fcnal-test.sh +++ b/tools/testing/selftests/net/fcnal-test.sh @@ -1825,8 +1825,9 @@ ipv4_addr_bind_vrf() for a in ${NSA_IP} ${VRF_IP} do log_start + show_hint "Socket not bound to VRF, but address is in VRF" run_cmd nettest -s -R -P icmp -l ${a} -b - log_test_addr ${a} $? 0 "Raw socket bind to local address" + log_test_addr ${a} $? 1 "Raw socket bind to local address" log_start run_cmd nettest -s -R -P icmp -l ${a} -I ${NSA_DEV} -b
Commit referenced below added negative socket bind tests for VRF. The socket binds should fail since the address to bind to is in a VRF yet the socket is not bound to the VRF or a device within it. Update the expected return code to check for 1 (bind failure) so the test passes when the bind fails as expected. Add a 'show_hint' comment to explain why the bind is expected to fail. Fixes: 75b2b2b3db4c ("selftests: Add ipv4 address bind tests to fcnal-test") Reported-by: Li Zhijian <lizhijian@fujitsu.com> Signed-off-by: David Ahern <dsahern@kernel.org> --- tools/testing/selftests/net/fcnal-test.sh | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)