| Message ID | 20211213080908.80723-1-jhp@endlessos.org (mailing list archive) |
|---|---|
| State | Awaiting Upstream |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | rtw88: pci: turn off PCI ASPM during NAPI polling | expand |
| Context | Check | Description |
|---|---|---|
| netdev/tree_selection | success | Not a local patch |
> -----Original Message----- > From: Jian-Hong Pan <jhp@endlessos.org> > Sent: Monday, December 13, 2021 4:09 PM > To: Pkshih <pkshih@realtek.com>; Bernie Huang <phhuang@realtek.com>; Kai-Heng Feng > <kai.heng.feng@canonical.com>; Yan-Hsuan Chuang <tony0620emma@gmail.com>; Kalle Valo > <kvalo@codeaurora.org> > Cc: linux-wireless@vger.kernel.org; netdev@vger.kernel.org; linux-kernel@vger.kernel.org; > linux@endlessos.org; Jian-Hong Pan <jhp@endlessos.org> > Subject: [PATCH] rtw88: pci: turn off PCI ASPM during NAPI polling > > The system on the machines equipped with RTL8821CE freezes randomly > until the PCI ASPM is disabled during NAPI poll function. > > Link: https://www.spinics.net/lists/linux-wireless/msg218387.html > Fixes: 9e2fd29864c5 ("rtw88: add napi support") > Signed-off-by: Jian-Hong Pan <jhp@endlessos.org> > --- > drivers/net/wireless/realtek/rtw88/pci.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/net/wireless/realtek/rtw88/pci.c b/drivers/net/wireless/realtek/rtw88/pci.c > index a7a6ebfaa203..a6fdddecd37d 100644 > --- a/drivers/net/wireless/realtek/rtw88/pci.c > +++ b/drivers/net/wireless/realtek/rtw88/pci.c > @@ -1658,6 +1658,7 @@ static int rtw_pci_napi_poll(struct napi_struct *napi, int budget) > priv); > int work_done = 0; > > + rtw_pci_link_ps(rtwdev, false); > while (work_done < budget) { > u32 work_done_once; > > @@ -1681,6 +1682,7 @@ static int rtw_pci_napi_poll(struct napi_struct *napi, int budget) > if (rtw_pci_get_hw_rx_ring_nr(rtwdev, rtwpci)) > napi_schedule(napi); > } > + rtw_pci_link_ps(rtwdev, true); > > return work_done; > } I think we need to add ref_cnt and only do this thing on specific chip and platform [1]. [1] https://lore.kernel.org/linux-wireless/e78b81f3a73c45b59f4c4d9f5b414508@realtek.com/T/#m95b22af523ea801fdb84225b87a84ca4f04bb33d -- Ping-Ke
diff --git a/drivers/net/wireless/realtek/rtw88/pci.c b/drivers/net/wireless/realtek/rtw88/pci.c index a7a6ebfaa203..a6fdddecd37d 100644 --- a/drivers/net/wireless/realtek/rtw88/pci.c +++ b/drivers/net/wireless/realtek/rtw88/pci.c @@ -1658,6 +1658,7 @@ static int rtw_pci_napi_poll(struct napi_struct *napi, int budget) priv); int work_done = 0; + rtw_pci_link_ps(rtwdev, false); while (work_done < budget) { u32 work_done_once; @@ -1681,6 +1682,7 @@ static int rtw_pci_napi_poll(struct napi_struct *napi, int budget) if (rtw_pci_get_hw_rx_ring_nr(rtwdev, rtwpci)) napi_schedule(napi); } + rtw_pci_link_ps(rtwdev, true); return work_done; }
The system on the machines equipped with RTL8821CE freezes randomly until the PCI ASPM is disabled during NAPI poll function. Link: https://www.spinics.net/lists/linux-wireless/msg218387.html Fixes: 9e2fd29864c5 ("rtw88: add napi support") Signed-off-by: Jian-Hong Pan <jhp@endlessos.org> --- drivers/net/wireless/realtek/rtw88/pci.c | 2 ++ 1 file changed, 2 insertions(+)