From patchwork Mon Dec 13 15:31:08 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Maciej Fijalkowski X-Patchwork-Id: 12674117 X-Patchwork-Delegate: kuba@kernel.org Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 55EFAC433F5 for ; Mon, 13 Dec 2021 15:31:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240113AbhLMPbe (ORCPT ); Mon, 13 Dec 2021 10:31:34 -0500 Received: from mga04.intel.com ([192.55.52.120]:4850 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237963AbhLMPbc (ORCPT ); Mon, 13 Dec 2021 10:31:32 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1639409492; x=1670945492; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=EVH+iAt06HTD4Z8tBf55CAuck0p5MH8rPhwNpMVK6ok=; b=PmqepvOyBD+fLGLgfydl/rv4Frqu3cvPa3w3f75i7+xQu/jyAwU4Jg7k S1ZWUnZk5YIFTo7nO0HS7tKyrCoIBm03rawYacrY6L5nUsRFTQ2gnQRDu Lq+WErQVzznPjgM58dnHWuyUjjJChafUhdxVOKBLHV27nDBoN8k9UKrDx 8kE9h55YQLbysucakjNTyUWWHTaIT1VfhEQMZY/Xpr67Cd/7wTt5Q0yz7 KACUhGiioTNFJxqwgeaf1RwWRe33zYqE02zEe8iz2Afdvtz3Hil267+PX tv4q/w2Fxyw35bZa3gyFAmhmXwihKUVFl7sgIfs2IuOhSpN8eFSERg3Fj g==; X-IronPort-AV: E=McAfee;i="6200,9189,10196"; a="237490511" X-IronPort-AV: E=Sophos;i="5.88,202,1635231600"; d="scan'208";a="237490511" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Dec 2021 07:31:32 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,202,1635231600"; d="scan'208";a="613864745" Received: from boxer.igk.intel.com ([10.102.20.173]) by orsmga004.jf.intel.com with ESMTP; 13 Dec 2021 07:31:28 -0800 From: Maciej Fijalkowski To: intel-wired-lan@lists.osuosl.org Cc: netdev@vger.kernel.org, bpf@vger.kernel.org, anthony.l.nguyen@intel.com, kuba@kernel.org, davem@davemloft.net, magnus.karlsson@intel.com, elza.mathew@intel.com, Alexander Lobakin , Maciej Fijalkowski Subject: [PATCH v2 intel-net 3/6] ice: remove dead store on XSK hotpath Date: Mon, 13 Dec 2021 16:31:08 +0100 Message-Id: <20211213153111.110877-4-maciej.fijalkowski@intel.com> X-Mailer: git-send-email 2.33.1 In-Reply-To: <20211213153111.110877-1-maciej.fijalkowski@intel.com> References: <20211213153111.110877-1-maciej.fijalkowski@intel.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org X-Patchwork-Delegate: kuba@kernel.org From: Alexander Lobakin The 'if (ntu == rx_ring->count)' block in ice_alloc_rx_buffers_zc() was previously residing in the loop, but after introducing the batched interface it is used only to wrap-around the NTU descriptor, thus no more need to assign 'xdp'. Fixes: db804cfc21e9 ("ice: Use the xsk batched rx allocation interface") Signed-off-by: Alexander Lobakin Acked-by: Maciej Fijalkowski Tested-by: Kiran Bhandare A Contingent Worker at Intel --- drivers/net/ethernet/intel/ice/ice_xsk.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/ethernet/intel/ice/ice_xsk.c b/drivers/net/ethernet/intel/ice/ice_xsk.c index c124229d98fe..27f5f64dcbd6 100644 --- a/drivers/net/ethernet/intel/ice/ice_xsk.c +++ b/drivers/net/ethernet/intel/ice/ice_xsk.c @@ -397,7 +397,6 @@ bool ice_alloc_rx_bufs_zc(struct ice_rx_ring *rx_ring, u16 count) ntu += nb_buffs; if (ntu == rx_ring->count) { rx_desc = ICE_RX_DESC(rx_ring, 0); - xdp = rx_ring->xdp_buf; ntu = 0; }