Message ID | 20211216111741.1387540-1-eric.dumazet@gmail.com (mailing list archive) |
---|---|
State | Accepted |
Commit | e28587cc491ef0f3c51258fdc87fbc386b1d4c59 |
Delegated to: | Netdev Maintainers |
Headers | show |
Series | [net] sit: do not call ipip6_dev_free() from sit_init_net() | expand |
Hello: This patch was applied to netdev/net.git (master) by Jakub Kicinski <kuba@kernel.org>: On Thu, 16 Dec 2021 03:17:41 -0800 you wrote: > From: Eric Dumazet <edumazet@google.com> > > ipip6_dev_free is sit dev->priv_destructor, already called > by register_netdevice() if something goes wrong. > > Alternative would be to make ipip6_dev_free() robust against > multiple invocations, but other drivers do not implement this > strategy. > > [...] Here is the summary with links: - [net] sit: do not call ipip6_dev_free() from sit_init_net() https://git.kernel.org/netdev/net/c/e28587cc491e You are awesome, thank you!
diff --git a/net/ipv6/sit.c b/net/ipv6/sit.c index 1b57ee36d6682e04085aa271c6c5c09e6e3a7b7e..8a3618a30632a8fab997edff82065a194dcaac1b 100644 --- a/net/ipv6/sit.c +++ b/net/ipv6/sit.c @@ -1933,7 +1933,6 @@ static int __net_init sit_init_net(struct net *net) return 0; err_reg_dev: - ipip6_dev_free(sitn->fb_tunnel_dev); free_netdev(sitn->fb_tunnel_dev); err_alloc_dev: return err;