| Message ID | 20211217070735.GC26548@kili (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | ddfbe18da55cbea41aaf57d442228edbd6cbbff1 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net-next] net: mtk_eth_soc: delete an unneeded variable | expand |
Hello: This patch was applied to netdev/net-next.git (master) by Jakub Kicinski <kuba@kernel.org>: On Fri, 17 Dec 2021 10:07:35 +0300 you wrote: > There is already an "int err" declared at the start of the function so > re-use that instead of declaring a shadow err variable. > > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> > --- > drivers/net/ethernet/mediatek/mtk_eth_soc.c | 1 - > 1 file changed, 1 deletion(-) Here is the summary with links: - [net-next] net: mtk_eth_soc: delete an unneeded variable https://git.kernel.org/netdev/net-next/c/ddfbe18da55c You are awesome, thank you!
diff --git a/drivers/net/ethernet/mediatek/mtk_eth_soc.c b/drivers/net/ethernet/mediatek/mtk_eth_soc.c index a068cf5c970f..bcb91b01e69f 100644 --- a/drivers/net/ethernet/mediatek/mtk_eth_soc.c +++ b/drivers/net/ethernet/mediatek/mtk_eth_soc.c @@ -2211,7 +2211,6 @@ static int mtk_open(struct net_device *dev) /* we run 2 netdevs on the same dma ring so we only bring it up once */ if (!refcount_read(ð->dma_refcnt)) { u32 gdm_config = MTK_GDMA_TO_PDMA; - int err; err = mtk_start_dma(eth); if (err)
There is already an "int err" declared at the start of the function so re-use that instead of declaring a shadow err variable. Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> --- drivers/net/ethernet/mediatek/mtk_eth_soc.c | 1 - 1 file changed, 1 deletion(-)