| Message ID | 20211217071037.GE26548@kili (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | ab9d0e2171be56bb3bcd0fe4bd8ae5d2f24e5a80 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net-next] net: ethernet: mtk_eth_soc: delete some dead code | expand |
Hello: This patch was applied to netdev/net-next.git (master) by Jakub Kicinski <kuba@kernel.org>: On Fri, 17 Dec 2021 10:10:37 +0300 you wrote: > The debugfs_create_dir() function never returns NULL. It does return > error pointers but in normal situations like this there is no need to > check for errors. > > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> > --- > drivers/net/ethernet/mediatek/mtk_ppe_debugfs.c | 3 --- > 1 file changed, 3 deletions(-) Here is the summary with links: - [net-next] net: ethernet: mtk_eth_soc: delete some dead code https://git.kernel.org/netdev/net-next/c/ab9d0e2171be You are awesome, thank you!
diff --git a/drivers/net/ethernet/mediatek/mtk_ppe_debugfs.c b/drivers/net/ethernet/mediatek/mtk_ppe_debugfs.c index 98b1d3577bcd..d4b482340cb9 100644 --- a/drivers/net/ethernet/mediatek/mtk_ppe_debugfs.c +++ b/drivers/net/ethernet/mediatek/mtk_ppe_debugfs.c @@ -207,9 +207,6 @@ int mtk_ppe_debugfs_init(struct mtk_ppe *ppe) struct dentry *root; root = debugfs_create_dir("mtk_ppe", NULL); - if (!root) - return -ENOMEM; - debugfs_create_file("entries", S_IRUGO, root, ppe, &fops_all); debugfs_create_file("bind", S_IRUGO, root, ppe, &fops_bind);
The debugfs_create_dir() function never returns NULL. It does return error pointers but in normal situations like this there is no need to check for errors. Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> --- drivers/net/ethernet/mediatek/mtk_ppe_debugfs.c | 3 --- 1 file changed, 3 deletions(-)