diff mbox series

net: vertexcom: Remove unneeded semicolon

Message ID 20211217084827.452729-1-deng.changcheng@zte.com.cn (mailing list archive)
State Not Applicable
Delegated to: Netdev Maintainers
Headers show
Series net: vertexcom: Remove unneeded semicolon | expand

Checks

Context Check Description
netdev/tree_selection success Guessing tree name failed - patch did not apply

Commit Message

CGEL Dec. 17, 2021, 8:48 a.m. UTC 
From: Changcheng Deng <deng.changcheng@zte.com.cn>

Fix the following coccicheck review:
./drivers/net/ethernet/vertexcom/mse102x.c: 414: 2-3: Unneeded semicolon

Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: Changcheng Deng <deng.changcheng@zte.com.cn>
---
 drivers/net/ethernet/vertexcom/mse102x.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Stefan Wahren Dec. 17, 2021, 9:42 a.m. UTC | #1 
Am 17.12.21 um 09:48 schrieb cgel.zte@gmail.com:
> From: Changcheng Deng <deng.changcheng@zte.com.cn>
>
> Fix the following coccicheck review:
> ./drivers/net/ethernet/vertexcom/mse102x.c: 414: 2-3: Unneeded semicolon
>
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: Changcheng Deng <deng.changcheng@zte.com.cn>
Reviewed-by: Stefan Wahren <stefan.wahren@i2se.com>
Jakub Kicinski Dec. 17, 2021, 4:47 p.m. UTC | #2 
On Fri, 17 Dec 2021 08:48:27 +0000 cgel.zte@gmail.com wrote:
> From: Changcheng Deng <deng.changcheng@zte.com.cn>
> 
> Fix the following coccicheck review:
> ./drivers/net/ethernet/vertexcom/mse102x.c: 414: 2-3: Unneeded semicolon

The Alibaba bot has beaten you to the punch, see commit 431b9b4d9789
("net: vertexcom: remove unneeded semicolon") in net-next.

Here we thought that "robot wars" will be like Terminator, what we got 
instead is false scarcity of concert tickets and auto-generated patches
which often don't build :(
diff mbox series

Patch

diff --git a/drivers/net/ethernet/vertexcom/mse102x.c b/drivers/net/ethernet/vertexcom/mse102x.c
index a3c2426e5597..89a31783fbb4 100644
--- a/drivers/net/ethernet/vertexcom/mse102x.c
+++ b/drivers/net/ethernet/vertexcom/mse102x.c
@@ -411,7 +411,7 @@  static int mse102x_tx_pkt_spi(struct mse102x_net *mse, struct sk_buff *txb,
 		} else {
 			msleep(20);
 		}
-	};
+	}
 
 	ret = mse102x_tx_frame_spi(mse, txb, pad);
 	if (ret)