| Message ID | 20211231153550.3807430-1-houtao1@huawei.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | BPF |
| Headers | show |
| Series | [bpf-next] bpf: support bpf_jit_enable=2 for CONFIG_BPF_JIT_ALWAYS_ON | expand |
On Fri, Dec 31, 2021 at 7:20 AM Hou Tao <houtao1@huawei.com> wrote: > > bpf_jit_enable=2 is used to dump the jited images for debug purpose, > however if CONFIG_BPF_JIT_ALWAYS_ON is enabled, its value is fixed > as one and can not be changed. So make the debug switch work again. > > Signed-off-by: Hou Tao <houtao1@huawei.com> That was discussed in the past: https://lore.kernel.org/bpf/20210326124030.1138964-1-Jianlin.Lv@arm.com/ The old point stands.
diff --git a/net/core/sysctl_net_core.c b/net/core/sysctl_net_core.c index 7b4d485aac7a..20e44427afa8 100644 --- a/net/core/sysctl_net_core.c +++ b/net/core/sysctl_net_core.c @@ -387,7 +387,7 @@ static struct ctl_table net_core_table[] = { .proc_handler = proc_dointvec_minmax_bpf_enable, # ifdef CONFIG_BPF_JIT_ALWAYS_ON .extra1 = SYSCTL_ONE, - .extra2 = SYSCTL_ONE, + .extra2 = &two, # else .extra1 = SYSCTL_ZERO, .extra2 = &two,
bpf_jit_enable=2 is used to dump the jited images for debug purpose, however if CONFIG_BPF_JIT_ALWAYS_ON is enabled, its value is fixed as one and can not be changed. So make the debug switch work again. Signed-off-by: Hou Tao <houtao1@huawei.com> --- net/core/sysctl_net_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)