| Message ID | 20220105152237.45991-1-jiapeng.chong@linux.alibaba.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 0cf765fb00ce083c017f2571ac449cf7912cdb06 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | sfc: Use swap() instead of open coding it | expand |
On Wed, Jan 05, 2022 at 11:22:37PM +0800, Jiapeng Chong wrote: > Clean the following coccicheck warning: > > ./drivers/net/ethernet/sfc/efx_channels.c:870:36-37: WARNING opportunity > for swap(). > > ./drivers/net/ethernet/sfc/efx_channels.c:824:36-37: WARNING opportunity > for swap(). > > Reported-by: Abaci Robot <abaci@linux.alibaba.com> > Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com> Acked-by: Martin Habets <habetsm.xilinx@gmail.com> > --- > drivers/net/ethernet/sfc/efx_channels.c | 14 ++++---------- > 1 file changed, 4 insertions(+), 10 deletions(-) > > diff --git a/drivers/net/ethernet/sfc/efx_channels.c b/drivers/net/ethernet/sfc/efx_channels.c > index b015d1f2e204..ead550ae2709 100644 > --- a/drivers/net/ethernet/sfc/efx_channels.c > +++ b/drivers/net/ethernet/sfc/efx_channels.c > @@ -819,11 +819,8 @@ int efx_realloc_channels(struct efx_nic *efx, u32 rxq_entries, u32 txq_entries) > old_txq_entries = efx->txq_entries; > efx->rxq_entries = rxq_entries; > efx->txq_entries = txq_entries; > - for (i = 0; i < efx->n_channels; i++) { > - channel = efx->channel[i]; > - efx->channel[i] = other_channel[i]; > - other_channel[i] = channel; > - } > + for (i = 0; i < efx->n_channels; i++) > + swap(efx->channel[i], other_channel[i]); > > /* Restart buffer table allocation */ > efx->next_buffer_table = next_buffer_table; > @@ -865,11 +862,8 @@ int efx_realloc_channels(struct efx_nic *efx, u32 rxq_entries, u32 txq_entries) > /* Swap back */ > efx->rxq_entries = old_rxq_entries; > efx->txq_entries = old_txq_entries; > - for (i = 0; i < efx->n_channels; i++) { > - channel = efx->channel[i]; > - efx->channel[i] = other_channel[i]; > - other_channel[i] = channel; > - } > + for (i = 0; i < efx->n_channels; i++) > + swap(efx->channel[i], other_channel[i]); > goto out; > } > > -- > 2.20.1.7.g153144c
Hello: This patch was applied to netdev/net-next.git (master) by David S. Miller <davem@davemloft.net>: On Wed, 5 Jan 2022 23:22:37 +0800 you wrote: > Clean the following coccicheck warning: > > ./drivers/net/ethernet/sfc/efx_channels.c:870:36-37: WARNING opportunity > for swap(). > > ./drivers/net/ethernet/sfc/efx_channels.c:824:36-37: WARNING opportunity > for swap(). > > [...] Here is the summary with links: - sfc: Use swap() instead of open coding it https://git.kernel.org/netdev/net-next/c/0cf765fb00ce You are awesome, thank you!
diff --git a/drivers/net/ethernet/sfc/efx_channels.c b/drivers/net/ethernet/sfc/efx_channels.c index b015d1f2e204..ead550ae2709 100644 --- a/drivers/net/ethernet/sfc/efx_channels.c +++ b/drivers/net/ethernet/sfc/efx_channels.c @@ -819,11 +819,8 @@ int efx_realloc_channels(struct efx_nic *efx, u32 rxq_entries, u32 txq_entries) old_txq_entries = efx->txq_entries; efx->rxq_entries = rxq_entries; efx->txq_entries = txq_entries; - for (i = 0; i < efx->n_channels; i++) { - channel = efx->channel[i]; - efx->channel[i] = other_channel[i]; - other_channel[i] = channel; - } + for (i = 0; i < efx->n_channels; i++) + swap(efx->channel[i], other_channel[i]); /* Restart buffer table allocation */ efx->next_buffer_table = next_buffer_table; @@ -865,11 +862,8 @@ int efx_realloc_channels(struct efx_nic *efx, u32 rxq_entries, u32 txq_entries) /* Swap back */ efx->rxq_entries = old_rxq_entries; efx->txq_entries = old_txq_entries; - for (i = 0; i < efx->n_channels; i++) { - channel = efx->channel[i]; - efx->channel[i] = other_channel[i]; - other_channel[i] = channel; - } + for (i = 0; i < efx->n_channels; i++) + swap(efx->channel[i], other_channel[i]); goto out; }
Clean the following coccicheck warning: ./drivers/net/ethernet/sfc/efx_channels.c:870:36-37: WARNING opportunity for swap(). ./drivers/net/ethernet/sfc/efx_channels.c:824:36-37: WARNING opportunity for swap(). Reported-by: Abaci Robot <abaci@linux.alibaba.com> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com> --- drivers/net/ethernet/sfc/efx_channels.c | 14 ++++---------- 1 file changed, 4 insertions(+), 10 deletions(-)