| Message ID | 20220108092555.17648-1-linmq006@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | ced4913efb0acc844ed65cc01d091a85d83a2082 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | softingcs: Fix memleak on registration failure in softingcs_probe | expand |
On 08.01.2022 09:25:51, Miaoqian Lin wrote: > In case device registration fails during module initialisation, the > platform device structure needs to be freed using platform_device_put() > to properly free all resources (e.g. the device name). > > Fixes: 0a0b7a5f7a04 ("can: add driver for Softing card") > Signed-off-by: Miaoqian Lin <linmq006@gmail.com> Thanks for your patch, a similar one has already been posted: | https://lore.kernel.org/all/20211222104843.6105-1-johan@kernel.org/ regards, Marc
Hello: This patch was applied to netdev/net.git (master) by Marc Kleine-Budde <mkl@pengutronix.de>: On Sat, 8 Jan 2022 09:25:51 +0000 you wrote: > In case device registration fails during module initialisation, the > platform device structure needs to be freed using platform_device_put() > to properly free all resources (e.g. the device name). > > Fixes: 0a0b7a5f7a04 ("can: add driver for Softing card") > Signed-off-by: Miaoqian Lin <linmq006@gmail.com> > > [...] Here is the summary with links: - softingcs: Fix memleak on registration failure in softingcs_probe https://git.kernel.org/netdev/net/c/ced4913efb0a You are awesome, thank you!
diff --git a/drivers/net/can/softing/softing_cs.c b/drivers/net/can/softing/softing_cs.c index 2e93ee792373..e5c939b63fa6 100644 --- a/drivers/net/can/softing/softing_cs.c +++ b/drivers/net/can/softing/softing_cs.c @@ -293,7 +293,7 @@ static int softingcs_probe(struct pcmcia_device *pcmcia) return 0; platform_failed: - kfree(dev); + platform_device_put(pdev); mem_failed: pcmcia_bad: pcmcia_failed:
In case device registration fails during module initialisation, the platform device structure needs to be freed using platform_device_put() to properly free all resources (e.g. the device name). Fixes: 0a0b7a5f7a04 ("can: add driver for Softing card") Signed-off-by: Miaoqian Lin <linmq006@gmail.com> --- drivers/net/can/softing/softing_cs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)