| Message ID | 20220111151053.4112161-1-mlichvar@redhat.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 2a4d75bfe41232608f5596a6d1369f92ccb20817 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net] net: fix sock_timestamping_bind_phc() to release device | expand |
Hello: This patch was applied to netdev/net.git (master) by David S. Miller <davem@davemloft.net>: On Tue, 11 Jan 2022 16:10:53 +0100 you wrote: > Don't forget to release the device in sock_timestamping_bind_phc() after > it was used to get the vclock indices. > > Fixes: d463126e23f1 ("net: sock: extend SO_TIMESTAMPING for PHC binding") > Signed-off-by: Miroslav Lichvar <mlichvar@redhat.com> > Cc: Yangbo Lu <yangbo.lu@nxp.com> > > [...] Here is the summary with links: - [net] net: fix sock_timestamping_bind_phc() to release device https://git.kernel.org/netdev/net/c/2a4d75bfe412 You are awesome, thank you!
diff --git a/net/core/sock.c b/net/core/sock.c index e21485ab285d..f32ec08a0c37 100644 --- a/net/core/sock.c +++ b/net/core/sock.c @@ -844,6 +844,8 @@ static int sock_timestamping_bind_phc(struct sock *sk, int phc_index) } num = ethtool_get_phc_vclocks(dev, &vclock_index); + dev_put(dev); + for (i = 0; i < num; i++) { if (*(vclock_index + i) == phc_index) { match = true;
Don't forget to release the device in sock_timestamping_bind_phc() after it was used to get the vclock indices. Fixes: d463126e23f1 ("net: sock: extend SO_TIMESTAMPING for PHC binding") Signed-off-by: Miroslav Lichvar <mlichvar@redhat.com> Cc: Yangbo Lu <yangbo.lu@nxp.com> --- net/core/sock.c | 2 ++ 1 file changed, 2 insertions(+)