| Message ID | 20220113031658.633290-1-imagedong@tencent.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | e80f2a0d194605553315de68284fc41969f81f62 |
| Delegated to: | BPF |
| Headers | show |
| Series | [bpf-next] test: selftests: remove unused various in sockmap_verdict_prog.c | expand |
| Context | Check | Description |
|---|---|---|
| netdev/tree_selection | success | Clearly marked for bpf-next |
| netdev/fixes_present | success | Fixes tag not required for -next series |
| netdev/subject_prefix | success | Link |
| netdev/cover_letter | success | Single patches do not need cover letters |
| netdev/patch_count | success | Link |
| netdev/header_inline | success | No static functions without inline keyword in header files |
| netdev/build_32bit | success | Errors and warnings before: 0 this patch: 0 |
| netdev/cc_maintainers | success | CCed 14 of 14 maintainers |
| netdev/build_clang | success | Errors and warnings before: 0 this patch: 0 |
| netdev/module_param | success | Was 0 now: 0 |
| netdev/verify_signedoff | success | Signed-off-by tag matches author and committer |
| netdev/verify_fixes | success | No Fixes tag |
| netdev/build_allmodconfig_warn | success | Errors and warnings before: 0 this patch: 0 |
| netdev/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 8 lines checked |
| netdev/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| netdev/source_inline | success | Was 0 now: 0 |
| bpf/vmtest-bpf-next-PR | success | PR summary |
| bpf/vmtest-bpf-next | success | VM_Test |
On Wed, Jan 12, 2022 at 7:17 PM <menglong8.dong@gmail.com> wrote: > > From: Menglong Dong <imagedong@tencent.com> > > 'lport' and 'rport' in bpf_prog1() of sockmap_verdict_prog.c is not > used, just remove them. > > Signed-off-by: Menglong Dong <imagedong@tencent.com> Acked-by: Song Liu <songliubraving@fb.com> > --- > tools/testing/selftests/bpf/progs/sockmap_parse_prog.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/tools/testing/selftests/bpf/progs/sockmap_parse_prog.c b/tools/testing/selftests/bpf/progs/sockmap_parse_prog.c > index 95d5b941bc1f..c9abfe3a11af 100644 > --- a/tools/testing/selftests/bpf/progs/sockmap_parse_prog.c > +++ b/tools/testing/selftests/bpf/progs/sockmap_parse_prog.c > @@ -7,8 +7,6 @@ int bpf_prog1(struct __sk_buff *skb) > { > void *data_end = (void *)(long) skb->data_end; > void *data = (void *)(long) skb->data; > - __u32 lport = skb->local_port; > - __u32 rport = skb->remote_port; > __u8 *d = data; > int err; > > -- > 2.34.1 >
Hello: This patch was applied to bpf/bpf-next.git (master) by Andrii Nakryiko <andrii@kernel.org>: On Thu, 13 Jan 2022 11:16:58 +0800 you wrote: > From: Menglong Dong <imagedong@tencent.com> > > 'lport' and 'rport' in bpf_prog1() of sockmap_verdict_prog.c is not > used, just remove them. > > Signed-off-by: Menglong Dong <imagedong@tencent.com> > > [...] Here is the summary with links: - [bpf-next] test: selftests: remove unused various in sockmap_verdict_prog.c https://git.kernel.org/bpf/bpf-next/c/e80f2a0d1946 You are awesome, thank you!
diff --git a/tools/testing/selftests/bpf/progs/sockmap_parse_prog.c b/tools/testing/selftests/bpf/progs/sockmap_parse_prog.c index 95d5b941bc1f..c9abfe3a11af 100644 --- a/tools/testing/selftests/bpf/progs/sockmap_parse_prog.c +++ b/tools/testing/selftests/bpf/progs/sockmap_parse_prog.c @@ -7,8 +7,6 @@ int bpf_prog1(struct __sk_buff *skb) { void *data_end = (void *)(long) skb->data_end; void *data = (void *)(long) skb->data; - __u32 lport = skb->local_port; - __u32 rport = skb->remote_port; __u8 *d = data; int err;