From patchwork Thu Jan 13 08:55:02 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?SsOpcsO0bWUgUG91aWxsZXI=?= X-Patchwork-Id: 12712433 X-Patchwork-Delegate: kuba@kernel.org Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EF941C433EF for ; Thu, 13 Jan 2022 08:56:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233208AbiAMI4c (ORCPT ); Thu, 13 Jan 2022 03:56:32 -0500 Received: from mail-mw2nam10on2077.outbound.protection.outlook.com ([40.107.94.77]:35104 "EHLO NAM10-MW2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S231576AbiAMI4I (ORCPT ); Thu, 13 Jan 2022 03:56:08 -0500 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=agKL6kuvioK5++3d3BFnQ5i4x8vjifQnZdp1enwzkx7fMCsEa5qhxwGQitEXKtyuz+qLHzZq+agbkmVkVGxXYwcmvGrwUI7CDp/OZrKB3y5j2ibQsQQp1G3/l1UprIkLfV7uIoQOJ/XrouuBFiJ6j2gNaarzEQF6hbvxPnwctz4gfujtz8yCXNt3tUs8dbnaEta6wNKDu/YbCfZ+B+xFbIm19fwktZ/xfPt5DjN/YdDDXWlog6BHYjNBd5N1674bunOTD1VwySz52onhtRHsOCmWxQJeqtYnSN1T1KAk6/CsXgMJxE8E10qPtXzM1PL5x15jdLUzEqFijErKkBUkJg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ksytp06C9OwuefGlf79uqyNLgoHJ7mhaEpS7Pt1UJYs=; b=AGGBkXJGB2eaqedvSQp4qdtMy13dYRB06qcbYN9ca2KW+FraM0Rk2GLSBt92YsJB03P84TPxyNK6i4rU9WSAHlj6SgCgTjQBq9hBGdgZcnPnykmcDWbNRqmAhjwwdpVI/4FfTW2EIUUAdaQUBpzXfx5IBtcumP3SW6yi2FgJU2qz3TdbjR1eskhjKgWa98xVpLNl+ODhSAKIOmFKKL2Hbk+iGUOtH3g/WAyLD2NM4Ks/PIPzOhx3w1EhLi3elpv+Bkll6fgds5l0W7ViwifIS4YlZBjFK3MLtAiGHZ4sWjphWw3Wkg6qmFaZQlwPbVt3iaM5uztUIlLtdQOnfi/lQw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=silabs.com; dmarc=pass action=none header.from=silabs.com; dkim=pass header.d=silabs.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=silabs.onmicrosoft.com; s=selector2-silabs-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ksytp06C9OwuefGlf79uqyNLgoHJ7mhaEpS7Pt1UJYs=; b=LPVc+Jwn497sS0C/f1omj4wSZ4nlaGQe3/CcOSHpOGQ8uJkl9QMBk+vIK4332pM1GGOxpgSCso1VxBgl6z54Uovcn/kFIKavXXX882PH522g8LBDDse4S4/WQccxoXDe8F4ZhJroa/TncuFvykXXoafbrNUU/4/trNAq3yT3P+8= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=silabs.com; Received: from PH0PR11MB5657.namprd11.prod.outlook.com (2603:10b6:510:ee::19) by BY5PR11MB4040.namprd11.prod.outlook.com (2603:10b6:a03:186::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4888.10; Thu, 13 Jan 2022 08:55:55 +0000 Received: from PH0PR11MB5657.namprd11.prod.outlook.com ([fe80::d031:da9e:71a:73e4]) by PH0PR11MB5657.namprd11.prod.outlook.com ([fe80::d031:da9e:71a:73e4%5]) with mapi id 15.20.4888.011; Thu, 13 Jan 2022 08:55:55 +0000 From: Jerome Pouiller To: devel@driverdev.osuosl.org, linux-wireless@vger.kernel.org Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Greg Kroah-Hartman , Kalle Valo , "David S . Miller" , =?utf-8?b?SsOpcsO0bWUgUG91aWxsZXI=?= Subject: [PATCH 09/31] staging: wfx: replace magic value by WFX_HIF_BUFFER_SIZE Date: Thu, 13 Jan 2022 09:55:02 +0100 Message-Id: <20220113085524.1110708-10-Jerome.Pouiller@silabs.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220113085524.1110708-1-Jerome.Pouiller@silabs.com> References: <20220113085524.1110708-1-Jerome.Pouiller@silabs.com> X-ClientProxiedBy: SA0PR11CA0117.namprd11.prod.outlook.com (2603:10b6:806:d1::32) To PH0PR11MB5657.namprd11.prod.outlook.com (2603:10b6:510:ee::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: bb07ffc4-2e60-4ba3-6e12-08d9d672829c X-MS-TrafficTypeDiagnostic: BY5PR11MB4040:EE_ X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:415; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: lIvIy7tqqeJyex6A8dqUAn1PnLtGwaZkKJTW/nPwXtmrJZftc8kTF7JkXJuv1plrpa/99rNaInnTXzdMLNkAOq8YknYk51LNE7Y/yvqxCQFrEfWoLEzDqop4kxpQOoWpOaO1KpCAh4/OoUrcE6FkumPwRUCNAyeRXUvBZRLHkAX76VTQeS0AGhJC8hApxsoEvazJ6AkdrO+K1McX9hOIPn2CqRvB0VF/o8SYDKS41YCAAlMltqS+yDVv7NWZTZZO1UPBE6zI/v2ficyOMRYUWkTY4hlNsF9xyWwUlGpBPTTZ5Z9Jb0T3w4/2O5zm4XcVPoTyGXnUoR4i5qgLI5yo8cEovku4/d6UNDNMo7FkKyoHcG0ukEmfTNhd0YBQxf60vU5JOuWwOLS10FEfdVxHGzocf6xIRn7PONIAz0owoYMXaYWyzCBknXpT5mmbmlYBUWOGcoz1QbkD7gTQjwaoM3qdW+2yQ4VpW0gAz4hc7humZeZArnauAwmYTdlW0Fx596yGkoFJ6bQXGSOslUS3XSD7XW4h4TPPIGW/GpOUCxCR2Fmp7GNKOZqgvsVnrxGbjIGUbYbJrPgad4JpVRUjQoOlv3syAVmF7m60urCreDGA7C0GOTaRr3GMsv8Ya5qWYuziydPEKVMy9sjXWW4BDg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR11MB5657.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(6506007)(508600001)(186003)(38100700002)(4326008)(8936002)(6512007)(6666004)(66946007)(83380400001)(1076003)(2616005)(54906003)(86362001)(66556008)(2906002)(66476007)(316002)(52116002)(36756003)(5660300002)(8676002)(6486002)(107886003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?ha7ooX1gbCwSaDS8noTr719Fan+J?= =?utf-8?q?4rLtMjePg2NswiNhnqwQn37UTbIL1WnNWAwfgelkR8Muc3dcg+w0tlUr3P2oPS2Z5?= =?utf-8?q?B3rcfQDxezboFLHSuWv/rXFnfm2dVKcx89wlqpQSxzDYu3dx/OTzM5iAUsZxOT79z?= =?utf-8?q?9hSlg9MdSygY9Ayl/wqhU+5au/F6a+UyrFYixtjsptYDQx+Drhy7L6xGjnTbl7532?= =?utf-8?q?2Gqnuo1h3ipJd6eJ72ZqO9VvSaK6YTBzmrjwB94fbquqXWYJrpKjsRIk1hlT/sExZ?= =?utf-8?q?+wVhBBPoKAK+SFy+zzk7PwCgYzjPih6gTlGxpXb4SUlgCLJmN0Bt0ezdhKUcn0aAN?= =?utf-8?q?RDU/YJdrP42aAb/UDvTXWqkv9QVD8dq2kEl1gbYJEm8DeGmoWGyck2d0CsW8WxoJB?= =?utf-8?q?/LKPks74O76zc0wdIrUeOMjhgcNVPvJ6eZWvfkISEYd0mzIsEAG4SPE4wEqcZKvLS?= =?utf-8?q?sEHau8UToU3Tkq4Bf2vZzsnHg7C7btbOotljmYpGOy+PvAMOMPVUl8Lb10e05pzPz?= =?utf-8?q?bzz/iohHuBf1XkECmm9WoTwK284AGBibJiVFOtaxhdbMXV+DdNufYFGPiwcyNzduI?= =?utf-8?q?q4idSJGh1bGhLbvMDGG8S3iMYjnOME1AD7OLqm1dEFsiyTX/Nc3Zg9hOxJSjbSmll?= =?utf-8?q?c8G56snvW/jXuVCtSnNG9+E4Ip04Q1EBJMb/wgIvkpynUoCGYsgCGj62J42/3hf+S?= =?utf-8?q?30CEWs28Q9BoQJvwG74HEUywueUniEZGOJ/XCcgR0W5vBrICnO19/LJZyluDgtdu7?= =?utf-8?q?zPWAsA/CyS59cCDCbr9zWrELVSQwa1QEd9WLshy3bJqz7wAndoc4hoOwDSf2yj9zu?= =?utf-8?q?Agk9GD0DyQsg8KylGjiP1VRWia0ffCLLYsKDRiLjPrzdZA/zSFCZMKzmFGBPnMkSL?= =?utf-8?q?NIv6biRLmX0wBaT/Ga1/JssMtlrSFmUlIUy33qhnoXNfcgxMLp6stVtz6ctaMBR/G?= =?utf-8?q?mlqy2AFHUOlU/EvDpqkx0UI5McCasduSBVkUTWl4dM0qdneLnbTVW8NdUMF1+bmQA?= =?utf-8?q?5M5iF36SE/f0oqnuTlMIeDVCs4LltUj2hjE/dmJ9WMqap2UxeeKDFqs/A8kcQDPIT?= =?utf-8?q?BX6MGsV8hsnBYNdyIzRWirMfTkvN2rx5iiX+69VJWpH1bh5EYWkrIUwo3ZPDBrRIk?= =?utf-8?q?i3zQ1Emwr8kqNwvo12ixKzVLMBS9ltTLE4Nf3dysK2OAblziiCFn/kpGT2p8QqRQ2?= =?utf-8?q?hPNMtxJm/Z0yN4YEZbBJEq6Y9pDHB5oBiERi6d626+MU1ArtFLgCOfY2AjXnMHo9z?= =?utf-8?q?EINF6JBgwBzbYpuXt2pj1V2u6GkeeaaMJSMzDk5kzKzO+k0lM3e4t3BfucMnUJuZv?= =?utf-8?q?i8p+n2UMwHh5Zh1499U1im+dOM8Vl2M0uGUkrP/YDySR/V8fk2L6Ex6y0bAgYgChn?= =?utf-8?q?pEaB6KcqVbq1xx6z3/FWWWonGeLerxb3hDUtQLNEr2ssxQNshkb4SSiBnaQtfuQgm?= =?utf-8?q?ns6tNChw34gl1F69Kf7unG8794ENatkriWu1ZII/JKDa/VHPNy3n70FQxFrMgqQVo?= =?utf-8?q?iQbw/iX3ENtN9+EwUnLFpcXc+v3i49BnkaTG7tGMj8bPOsBVXLUGr0/5PzFw+VtKf?= =?utf-8?q?vway+pOQtVkETVw26wids+Wl1ATEhgQOy4ZiDpyn/oqMj3MQavoA1A=3D?= X-OriginatorOrg: silabs.com X-MS-Exchange-CrossTenant-Network-Message-Id: bb07ffc4-2e60-4ba3-6e12-08d9d672829c X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5657.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jan 2022 08:55:55.7728 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 54dbd822-5231-4b20-944d-6f4abcd541fb X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 4k9f5C/NEumxgNvW9xfcAz5rcPeCB88gQHtbcqYNz0iJ+7NC+jJ2GpoNe9l5XyDp17bx2bLMG6hDwUXMbykBkw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR11MB4040 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Jérôme Pouiller Magic values are not recommended. Signed-off-by: Jérôme Pouiller --- drivers/staging/wfx/hwio.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/staging/wfx/hwio.c b/drivers/staging/wfx/hwio.c index a2a37efc51a6..977b9325f496 100644 --- a/drivers/staging/wfx/hwio.c +++ b/drivers/staging/wfx/hwio.c @@ -15,6 +15,8 @@ #include "bus.h" #include "traces.h" +#define WFX_HIF_BUFFER_SIZE 0x2000 + static int read32(struct wfx_dev *wdev, int reg, u32 *val) { int ret; @@ -103,7 +105,7 @@ static int indirect_read(struct wfx_dev *wdev, int reg, u32 addr, u32 cfg; u32 prefetch; - WARN_ON(len >= 0x2000); + WARN_ON(len >= WFX_HIF_BUFFER_SIZE); WARN_ON(reg != WFX_REG_AHB_DPORT && reg != WFX_REG_SRAM_DPORT); if (reg == WFX_REG_AHB_DPORT) @@ -151,7 +153,7 @@ static int indirect_write(struct wfx_dev *wdev, int reg, u32 addr, { int ret; - WARN_ON(len >= 0x2000); + WARN_ON(len >= WFX_HIF_BUFFER_SIZE); WARN_ON(reg != WFX_REG_AHB_DPORT && reg != WFX_REG_SRAM_DPORT); ret = write32(wdev, WFX_REG_BASE_ADDR, addr); if (ret < 0)