| Message ID | 20220121173449.26918-1-justin.iurman@uliege.be (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net] selftests: net: ioam: Fixes b63c5478e9 | expand |
On Fri, 21 Jan 2022 18:34:49 +0100 Justin Iurman wrote: > Subject: [PATCH net] selftests: net: ioam: Fixes b63c5478e9 selftests: net: ioam: expect support for Queue depth data > Date: Fri, 21 Jan 2022 18:34:49 +0100 > X-Mailer: git-send-email 2.25.1 > > The IOAM queue-depth data field was added a few weeks ago, but the test unit > was not updated accordingly. Here is the fix, thanks for the report. s/Here.*// > Reported-by: kernel test robot <oliver.sang@intel.com> Fixes: b63c5478e9cb ("ipv6: ioam: Support for Queue depth data field") > Signed-off-by: Justin Iurman <justin.iurman@uliege.be> Applied, thanks!
diff --git a/tools/testing/selftests/net/ioam6_parser.c b/tools/testing/selftests/net/ioam6_parser.c index 8f6997d35816..d9d1d4190126 100644 --- a/tools/testing/selftests/net/ioam6_parser.c +++ b/tools/testing/selftests/net/ioam6_parser.c @@ -240,11 +240,8 @@ static int check_ioam6_data(__u8 **p, struct ioam6_trace_hdr *ioam6h, *p += sizeof(__u32); } - if (ioam6h->type.bit6) { - if (__be32_to_cpu(*((__u32 *)*p)) != 0xffffffff) - return 1; + if (ioam6h->type.bit6) *p += sizeof(__u32); - } if (ioam6h->type.bit7) { if (__be32_to_cpu(*((__u32 *)*p)) != 0xffffffff)
The IOAM queue-depth data field was added a few weeks ago, but the test unit was not updated accordingly. Here is the fix, thanks for the report. Reported-by: kernel test robot <oliver.sang@intel.com> Signed-off-by: Justin Iurman <justin.iurman@uliege.be> --- tools/testing/selftests/net/ioam6_parser.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-)