| Message ID | 20220201212503.731732-1-nathan@kernel.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 7f3bdbc3f13146eb9d07de81ea71f551587a384b |
| Delegated to: | BPF |
| Headers | show |
| Series | tools/resolve_btfids: Do not print any commands when building silently | expand |
| Context | Check | Description |
|---|---|---|
| bpf/vmtest-bpf-next-PR | success | PR summary |
| bpf/vmtest-bpf-next | success | VM_Test |
| netdev/tree_selection | success | Not a local patch |
Hello: This patch was applied to bpf/bpf.git (master) by Daniel Borkmann <daniel@iogearbox.net>: On Tue, 1 Feb 2022 14:25:04 -0700 you wrote: > When building with 'make -s', there is some output from resolve_btfids: > > $ make -sj"$(nproc)" oldconfig prepare > MKDIR .../tools/bpf/resolve_btfids/libbpf/ > MKDIR .../tools/bpf/resolve_btfids//libsubcmd > LINK resolve_btfids > > [...] Here is the summary with links: - tools/resolve_btfids: Do not print any commands when building silently https://git.kernel.org/bpf/bpf/c/7f3bdbc3f131 You are awesome, thank you!
diff --git a/tools/bpf/resolve_btfids/Makefile b/tools/bpf/resolve_btfids/Makefile index 9ddeca947635..320a88ac28c9 100644 --- a/tools/bpf/resolve_btfids/Makefile +++ b/tools/bpf/resolve_btfids/Makefile @@ -9,7 +9,11 @@ ifeq ($(V),1) msg = else Q = @ - msg = @printf ' %-8s %s%s\n' "$(1)" "$(notdir $(2))" "$(if $(3), $(3))"; + ifeq ($(silent),1) + msg = + else + msg = @printf ' %-8s %s%s\n' "$(1)" "$(notdir $(2))" "$(if $(3), $(3))"; + endif MAKEFLAGS=--no-print-directory endif
When building with 'make -s', there is some output from resolve_btfids: $ make -sj"$(nproc)" oldconfig prepare MKDIR .../tools/bpf/resolve_btfids/libbpf/ MKDIR .../tools/bpf/resolve_btfids//libsubcmd LINK resolve_btfids Silent mode means that no information should be emitted about what is currently being done. Use the $(silent) variable from Makefile.include to avoid defining the msg macro so that there is no information printed. Fixes: fbbb68de80a4 ("bpf: Add resolve_btfids tool to resolve BTF IDs in ELF object") Signed-off-by: Nathan Chancellor <nathan@kernel.org> --- This should apply to either bpf or bpf-next so no subject prefix. I would prefer it goes in sooner rather than later but I'll leave that up to you all. tools/bpf/resolve_btfids/Makefile | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) base-commit: 26291c54e111ff6ba87a164d85d4a4e134b7315c