diff mbox series

[net-next] ref_tracker: remove filter_irq_stacks() call

Message ID 20220205172711.3775171-1-eric.dumazet@gmail.com (mailing list archive)
State Accepted
Commit c2d1e3df4af59261777b39c2e47476acd4d1cbeb
Delegated to: Netdev Maintainers
Headers show
Series [net-next] ref_tracker: remove filter_irq_stacks() call | expand

Checks

Context Check Description
netdev/tree_selection success Clearly marked for net-next
netdev/fixes_present success Fixes tag not required for -next series
netdev/subject_prefix success Link
netdev/cover_letter success Single patches do not need cover letters
netdev/patch_count success Link
netdev/header_inline success No static functions without inline keyword in header files
netdev/build_32bit success Errors and warnings before: 2 this patch: 2
netdev/cc_maintainers success CCed 2 of 2 maintainers
netdev/build_clang success Errors and warnings before: 18 this patch: 18
netdev/module_param success Was 0 now: 0
netdev/verify_signedoff success Signed-off-by tag matches author and committer
netdev/verify_fixes success No Fixes tag
netdev/build_allmodconfig_warn success Errors and warnings before: 7 this patch: 7
netdev/checkpatch success total: 0 errors, 0 warnings, 0 checks, 14 lines checked
netdev/kdoc success Errors and warnings before: 0 this patch: 0
netdev/source_inline success Was 0 now: 0

Commit Message

Eric Dumazet Feb. 5, 2022, 5:27 p.m. UTC 
From: Eric Dumazet <edumazet@google.com>

After commit e94006608949 ("lib/stackdepot: always do filter_irq_stacks()
in stack_depot_save()") it became unnecessary to filter the stack
before calling stack_depot_save().

Signed-off-by: Eric Dumazet <edumazet@google.com>
Cc: Marco Elver <elver@google.com>
Cc: Alexander Potapenko <glider@google.com>
Cc: Dmitry Vyukov <dvyukov@google.com>
---
 lib/ref_tracker.c | 2 --
 1 file changed, 2 deletions(-)

Comments

Marco Elver Feb. 7, 2022, 7 a.m. UTC | #1 
On Sat, 5 Feb 2022 at 18:27, Eric Dumazet <eric.dumazet@gmail.com> wrote:
>
> From: Eric Dumazet <edumazet@google.com>
>
> After commit e94006608949 ("lib/stackdepot: always do filter_irq_stacks()
> in stack_depot_save()") it became unnecessary to filter the stack
> before calling stack_depot_save().
>
> Signed-off-by: Eric Dumazet <edumazet@google.com>
> Cc: Marco Elver <elver@google.com>

Reviewed-by: Marco Elver <elver@google.com>


> Cc: Alexander Potapenko <glider@google.com>
> Cc: Dmitry Vyukov <dvyukov@google.com>
> ---
>  lib/ref_tracker.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/lib/ref_tracker.c b/lib/ref_tracker.c
> index 9c0c2e09df666d19aba441f568762afbd1cad4d0..dc7b14aa3431e2bf7a97a7e78220f04da144563d 100644
> --- a/lib/ref_tracker.c
> +++ b/lib/ref_tracker.c
> @@ -89,7 +89,6 @@ int ref_tracker_alloc(struct ref_tracker_dir *dir,
>                 return -ENOMEM;
>         }
>         nr_entries = stack_trace_save(entries, ARRAY_SIZE(entries), 1);
> -       nr_entries = filter_irq_stacks(entries, nr_entries);
>         tracker->alloc_stack_handle = stack_depot_save(entries, nr_entries, gfp);
>
>         spin_lock_irqsave(&dir->lock, flags);
> @@ -120,7 +119,6 @@ int ref_tracker_free(struct ref_tracker_dir *dir,
>                 return -EEXIST;
>         }
>         nr_entries = stack_trace_save(entries, ARRAY_SIZE(entries), 1);
> -       nr_entries = filter_irq_stacks(entries, nr_entries);
>         stack_handle = stack_depot_save(entries, nr_entries, GFP_ATOMIC);
>
>         spin_lock_irqsave(&dir->lock, flags);
> --
> 2.35.0.263.gb82422642f-goog
>
patchwork-bot+netdevbpf@kernel.org Feb. 7, 2022, 11:40 a.m. UTC | #2 
Hello:

This patch was applied to netdev/net-next.git (master)
by David S. Miller <davem@davemloft.net>:

On Sat,  5 Feb 2022 09:27:11 -0800 you wrote:
> From: Eric Dumazet <edumazet@google.com>
> 
> After commit e94006608949 ("lib/stackdepot: always do filter_irq_stacks()
> in stack_depot_save()") it became unnecessary to filter the stack
> before calling stack_depot_save().
> 
> Signed-off-by: Eric Dumazet <edumazet@google.com>
> Cc: Marco Elver <elver@google.com>
> Cc: Alexander Potapenko <glider@google.com>
> Cc: Dmitry Vyukov <dvyukov@google.com>
> 
> [...]

Here is the summary with links:
  - [net-next] ref_tracker: remove filter_irq_stacks() call
    https://git.kernel.org/netdev/net-next/c/c2d1e3df4af5

You are awesome, thank you!
diff mbox series

Patch

diff --git a/lib/ref_tracker.c b/lib/ref_tracker.c
index 9c0c2e09df666d19aba441f568762afbd1cad4d0..dc7b14aa3431e2bf7a97a7e78220f04da144563d 100644
--- a/lib/ref_tracker.c
+++ b/lib/ref_tracker.c
@@ -89,7 +89,6 @@  int ref_tracker_alloc(struct ref_tracker_dir *dir,
 		return -ENOMEM;
 	}
 	nr_entries = stack_trace_save(entries, ARRAY_SIZE(entries), 1);
-	nr_entries = filter_irq_stacks(entries, nr_entries);
 	tracker->alloc_stack_handle = stack_depot_save(entries, nr_entries, gfp);
 
 	spin_lock_irqsave(&dir->lock, flags);
@@ -120,7 +119,6 @@  int ref_tracker_free(struct ref_tracker_dir *dir,
 		return -EEXIST;
 	}
 	nr_entries = stack_trace_save(entries, ARRAY_SIZE(entries), 1);
-	nr_entries = filter_irq_stacks(entries, nr_entries);
 	stack_handle = stack_depot_save(entries, nr_entries, GFP_ATOMIC);
 
 	spin_lock_irqsave(&dir->lock, flags);