diff mbox series

[net,v2] tipc: rate limit warning for received illegal binding update

Message ID 20220209032237.1161090-1-jmaloy@redhat.com (mailing list archive)
State Accepted
Commit c7223d687758462826a20e9735305d55bb874c70
Delegated to: Netdev Maintainers
Headers show
Series [net,v2] tipc: rate limit warning for received illegal binding update | expand

Checks

Context Check Description
netdev/tree_selection success Clearly marked for net
netdev/fixes_present success Fixes tag present in non-next series
netdev/subject_prefix success Link
netdev/cover_letter success Single patches do not need cover letters
netdev/patch_count success Link
netdev/header_inline success No static functions without inline keyword in header files
netdev/build_32bit success Errors and warnings before: 0 this patch: 0
netdev/cc_maintainers fail 1 blamed authors not CCed: per.liden@nospam.ericsson.com; 1 maintainers not CCed: per.liden@nospam.ericsson.com
netdev/build_clang success Errors and warnings before: 0 this patch: 0
netdev/module_param success Was 0 now: 0
netdev/verify_signedoff success Signed-off-by tag matches author and committer
netdev/verify_fixes success Fixes tag looks correct
netdev/build_allmodconfig_warn success Errors and warnings before: 0 this patch: 0
netdev/checkpatch success total: 0 errors, 0 warnings, 0 checks, 8 lines checked
netdev/kdoc success Errors and warnings before: 0 this patch: 0
netdev/source_inline success Was 0 now: 0

Commit Message

Jon Maloy Feb. 9, 2022, 3:22 a.m. UTC 
From: Jon Maloy <jmaloy@redhat.com>

It would be easy to craft a message containing an illegal binding table
update operation. This is handled correctly by the code, but the
corresponding warning printout is not rate limited as is should be.
We fix this now.

Fixes: b97bf3fd8f6a ("[TIPC] Initial merge")
Signed-off-by: Jon Maloy <jmaloy@redhat.com>

---
v2: Added 'Fixes' line in commit log

Signed-off-by: Jon Maloy <jmaloy@redhat.com>
---
 net/tipc/name_distr.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

patchwork-bot+netdevbpf@kernel.org Feb. 9, 2022, 12:50 p.m. UTC | #1 
Hello:

This patch was applied to netdev/net.git (master)
by David S. Miller <davem@davemloft.net>:

On Tue,  8 Feb 2022 22:22:37 -0500 you wrote:
> From: Jon Maloy <jmaloy@redhat.com>
> 
> It would be easy to craft a message containing an illegal binding table
> update operation. This is handled correctly by the code, but the
> corresponding warning printout is not rate limited as is should be.
> We fix this now.
> 
> [...]

Here is the summary with links:
  - [net,v2] tipc: rate limit warning for received illegal binding update
    https://git.kernel.org/netdev/net/c/c7223d687758

You are awesome, thank you!
diff mbox series

Patch

diff --git a/net/tipc/name_distr.c b/net/tipc/name_distr.c
index bda902caa814..8267b751a526 100644
--- a/net/tipc/name_distr.c
+++ b/net/tipc/name_distr.c
@@ -313,7 +313,7 @@  static bool tipc_update_nametbl(struct net *net, struct distr_item *i,
 		pr_warn_ratelimited("Failed to remove binding %u,%u from %u\n",
 				    ua.sr.type, ua.sr.lower, node);
 	} else {
-		pr_warn("Unrecognized name table message received\n");
+		pr_warn_ratelimited("Unknown name table message received\n");
 	}
 	return false;
 }