| Message ID | 20220209052141.140063-1-connoro@google.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | BPF |
| Headers | show |
| Series | [bpf-next] lib/Kconfig.debug: add prompt for kernel module BTF | expand |
| Context | Check | Description |
|---|---|---|
| netdev/tree_selection | success | Clearly marked for bpf-next |
| netdev/fixes_present | success | Fixes tag not required for -next series |
| netdev/subject_prefix | success | Link |
| netdev/cover_letter | success | Single patches do not need cover letters |
| netdev/patch_count | success | Link |
| netdev/header_inline | success | No static functions without inline keyword in header files |
| netdev/build_32bit | success | Errors and warnings before: 0 this patch: 0 |
| netdev/cc_maintainers | warning | 1 maintainers not CCed: akpm@linux-foundation.org |
| netdev/build_clang | success | Errors and warnings before: 0 this patch: 0 |
| netdev/module_param | success | Was 0 now: 0 |
| netdev/verify_signedoff | success | Signed-off-by tag matches author and committer |
| netdev/verify_fixes | success | No Fixes tag |
| netdev/build_allmodconfig_warn | success | Errors and warnings before: 0 this patch: 0 |
| netdev/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 8 lines checked |
| netdev/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| netdev/source_inline | success | Was 0 now: 0 |
| bpf/vmtest-bpf-next-PR | fail | PR summary |
| bpf/vmtest-bpf-next | fail | VM_Test |
On 2/8/22 9:21 PM, Connor O'Brien wrote: > With DEBUG_INFO_BTF_MODULES enabled, a BTF mismatch between vmlinux > and a separately-built module prevents the module from loading, even > if the ABI is otherwise compatible and the module would otherwise load > without issues. Currently this can be avoided only by disabling BTF > entirely; disabling just module BTF would be sufficient but is not > possible with the current Kconfig. > > Add a prompt for DEBUG_INFO_BTF_MODULES to allow it to be disabled > independently. > > Signed-off-by: Connor O'Brien <connoro@google.com> Acked-by: Yonghong Song <yhs@fb.com>
diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug index 1555da672275..a6bbd4bb2bde 100644 --- a/lib/Kconfig.debug +++ b/lib/Kconfig.debug @@ -334,7 +334,7 @@ config PAHOLE_HAS_BTF_TAG these attributes, so make the config depend on CC_IS_CLANG. config DEBUG_INFO_BTF_MODULES - def_bool y + bool "Generate BTF typeinfo for modules" depends on DEBUG_INFO_BTF && MODULES && PAHOLE_HAS_SPLIT_BTF help Generate compact split BTF type information for kernel modules.
With DEBUG_INFO_BTF_MODULES enabled, a BTF mismatch between vmlinux and a separately-built module prevents the module from loading, even if the ABI is otherwise compatible and the module would otherwise load without issues. Currently this can be avoided only by disabling BTF entirely; disabling just module BTF would be sufficient but is not possible with the current Kconfig. Add a prompt for DEBUG_INFO_BTF_MODULES to allow it to be disabled independently. Signed-off-by: Connor O'Brien <connoro@google.com> --- lib/Kconfig.debug | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)