| Message ID | 20220209082820.2210753-1-o.rempel@pengutronix.de (mailing list archive) |
|---|---|
| State | Not Applicable |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net-next,v1] dt-bindings: net: ethernet-controller: document label property | expand |
On Wed, Feb 9, 2022 at 2:28 AM Oleksij Rempel <o.rempel@pengutronix.de> wrote: > > "label" provides human readable name used on a box, board or schematic > to identify Ethernet port. Do you still need this? > Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de> > --- > .../devicetree/bindings/net/ethernet-controller.yaml | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/Documentation/devicetree/bindings/net/ethernet-controller.yaml b/Documentation/devicetree/bindings/net/ethernet-controller.yaml > index 34c5463abcec..817794e56227 100644 > --- a/Documentation/devicetree/bindings/net/ethernet-controller.yaml > +++ b/Documentation/devicetree/bindings/net/ethernet-controller.yaml > @@ -13,6 +13,10 @@ properties: > $nodename: > pattern: "^ethernet(@.*)?$" > > + label: > + $ref: /schemas/types.yaml#/definitions/string > + description: Human readable label on a port of a box. > + > local-mac-address: > description: > Specifies the MAC address that was assigned to the network device. > -- > 2.30.2 >
On Wed, Feb 09, 2022 at 09:34:36AM -0600, Rob Herring wrote: > On Wed, Feb 9, 2022 at 2:28 AM Oleksij Rempel <o.rempel@pengutronix.de> wrote: > > > > "label" provides human readable name used on a box, board or schematic > > to identify Ethernet port. > > Do you still need this? Yes. No need to force label based name from kernel, but user space should be able to use it to rename interface if needed or use it for GUI. Otherwise user space will need to have date base of all boards to provide this information. Regards, Oleksij
On Wed, 09 Feb 2022 09:28:20 +0100, Oleksij Rempel wrote: > "label" provides human readable name used on a box, board or schematic > to identify Ethernet port. > > Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de> > --- > .../devicetree/bindings/net/ethernet-controller.yaml | 4 ++++ > 1 file changed, 4 insertions(+) > Applied, thanks!
diff --git a/Documentation/devicetree/bindings/net/ethernet-controller.yaml b/Documentation/devicetree/bindings/net/ethernet-controller.yaml index 34c5463abcec..817794e56227 100644 --- a/Documentation/devicetree/bindings/net/ethernet-controller.yaml +++ b/Documentation/devicetree/bindings/net/ethernet-controller.yaml @@ -13,6 +13,10 @@ properties: $nodename: pattern: "^ethernet(@.*)?$" + label: + $ref: /schemas/types.yaml#/definitions/string + description: Human readable label on a port of a box. + local-mac-address: description: Specifies the MAC address that was assigned to the network device.
"label" provides human readable name used on a box, board or schematic to identify Ethernet port. Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de> --- .../devicetree/bindings/net/ethernet-controller.yaml | 4 ++++ 1 file changed, 4 insertions(+)