Message ID | 20220209155743.3167775-1-ioana.ciornei@nxp.com (mailing list archive) |
---|---|
State | Accepted |
Commit | 9ccc6e0c8959a019bb40f6b18704b142c04b19a8 |
Delegated to: | Netdev Maintainers |
Headers | show |
Series | [net] dpaa2-eth: unregister the netdev before disconnecting from the PHY | expand |
Hello: This patch was applied to netdev/net.git (master) by David S. Miller <davem@davemloft.net>: On Wed, 9 Feb 2022 17:57:43 +0200 you wrote: > From: Robert-Ionut Alexa <robert-ionut.alexa@nxp.com> > > The netdev should be unregistered before we are disconnecting from the > MAC/PHY so that the dev_close callback is called and the PHY and the > phylink workqueues are actually stopped before we are disconnecting and > destroying the phylink instance. > > [...] Here is the summary with links: - [net] dpaa2-eth: unregister the netdev before disconnecting from the PHY https://git.kernel.org/netdev/net/c/9ccc6e0c8959 You are awesome, thank you!
diff --git a/drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c b/drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c index e985ae008a97..dd9385d15f6b 100644 --- a/drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c +++ b/drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c @@ -4523,12 +4523,12 @@ static int dpaa2_eth_remove(struct fsl_mc_device *ls_dev) #ifdef CONFIG_DEBUG_FS dpaa2_dbg_remove(priv); #endif + + unregister_netdev(net_dev); rtnl_lock(); dpaa2_eth_disconnect_mac(priv); rtnl_unlock(); - unregister_netdev(net_dev); - dpaa2_eth_dl_port_del(priv); dpaa2_eth_dl_traps_unregister(priv); dpaa2_eth_dl_free(priv);