diff mbox series

net: dsa: qca8k: fix noderef.cocci warnings

Message ID 20220209221304.GA17529@d2214a582157 (mailing list archive)
State Superseded
Delegated to: Netdev Maintainers
Headers show
Series net: dsa: qca8k: fix noderef.cocci warnings | expand

Checks

Context Check Description
netdev/tree_selection success Not a local patch

Commit Message

kernel test robot Feb. 9, 2022, 10:13 p.m. UTC 
From: kernel test robot <lkp@intel.com>

drivers/net/dsa/qca8k.c:422:37-43: ERROR: application of sizeof to pointer

 sizeof when applied to a pointer typed expression gives the size of
 the pointer

Generated by: scripts/coccinelle/misc/noderef.cocci

Fixes: 90386223f44e ("net: dsa: qca8k: add support for larger read/write size with mgmt Ethernet")
CC: Ansuel Smith <ansuelsmth@gmail.com>
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head:   10207e3a840b47b5eae573486a88fb6e29884f77
commit: 90386223f44e2a751d7e9e9ac8f78ea33358a891 [2955/4656] net: dsa: qca8k: add support for larger read/write size with mgmt Ethernet
:::::: branch date: 16 hours ago
:::::: commit date: 7 days ago

 qca8k.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Florian Fainelli Feb. 10, 2022, 3:30 a.m. UTC | #1 
On 2/9/2022 2:13 PM, kernel test robot wrote:
> From: kernel test robot <lkp@intel.com>
> 
> drivers/net/dsa/qca8k.c:422:37-43: ERROR: application of sizeof to pointer
> 
>   sizeof when applied to a pointer typed expression gives the size of
>   the pointer
> 
> Generated by: scripts/coccinelle/misc/noderef.cocci
> 
> Fixes: 90386223f44e ("net: dsa: qca8k: add support for larger read/write size with mgmt Ethernet")
> CC: Ansuel Smith <ansuelsmth@gmail.com>
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: kernel test robot <lkp@intel.com>

Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
Jakub Kicinski Feb. 10, 2022, 6:59 p.m. UTC | #2 
On Wed, 9 Feb 2022 19:30:48 -0800 Florian Fainelli wrote:
> On 2/9/2022 2:13 PM, kernel test robot wrote:
> > From: kernel test robot <lkp@intel.com>
> > 
> > drivers/net/dsa/qca8k.c:422:37-43: ERROR: application of sizeof to pointer
> > 
> >   sizeof when applied to a pointer typed expression gives the size of
> >   the pointer
> > 
> > Generated by: scripts/coccinelle/misc/noderef.cocci
> > 
> > Fixes: 90386223f44e ("net: dsa: qca8k: add support for larger read/write size with mgmt Ethernet")
> > CC: Ansuel Smith <ansuelsmth@gmail.com>
> > Reported-by: kernel test robot <lkp@intel.com>
> > Signed-off-by: kernel test robot <lkp@intel.com>  
> 
> > qca8k.c |    2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)

kbuild folks, would it be easy to switch to including full path here?
It seems like our CI expects that and ignores this patch.

> Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>

Applied, thanks!
Chen, Rong A Feb. 11, 2022, 6:36 a.m. UTC | #3 
On 2/11/2022 2:59 AM, Jakub Kicinski wrote:
> On Wed, 9 Feb 2022 19:30:48 -0800 Florian Fainelli wrote:
>> On 2/9/2022 2:13 PM, kernel test robot wrote:
>>> From: kernel test robot <lkp@intel.com>
>>>
>>> drivers/net/dsa/qca8k.c:422:37-43: ERROR: application of sizeof to pointer
>>>
>>>    sizeof when applied to a pointer typed expression gives the size of
>>>    the pointer
>>>
>>> Generated by: scripts/coccinelle/misc/noderef.cocci
>>>
>>> Fixes: 90386223f44e ("net: dsa: qca8k: add support for larger read/write size with mgmt Ethernet")
>>> CC: Ansuel Smith <ansuelsmth@gmail.com>
>>> Reported-by: kernel test robot <lkp@intel.com>
>>> Signed-off-by: kernel test robot <lkp@intel.com>
>>
>>> qca8k.c |    2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> kbuild folks, would it be easy to switch to including full path here?
> It seems like our CI expects that and ignores this patch.

Hi Jakub,

Thanks for the advice, will change it.

Best Regards,
Rong Chen

> 
>> Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
> 
> Applied, thanks!
> _______________________________________________
> kbuild-all mailing list -- kbuild-all@lists.01.org
> To unsubscribe send an email to kbuild-all-leave@lists.01.org
>
diff mbox series

Patch

--- a/drivers/net/dsa/qca8k.c
+++ b/drivers/net/dsa/qca8k.c
@@ -419,7 +419,7 @@  qca8k_regmap_read(void *ctx, uint32_t re
 	u16 r1, r2, page;
 	int ret;
 
-	if (!qca8k_read_eth(priv, reg, val, sizeof(val)))
+	if (!qca8k_read_eth(priv, reg, val, sizeof(*val)))
 		return 0;
 
 	qca8k_split_addr(reg, &r1, &r2, &page);