diff mbox series

net: dsa: qca8k: fix noderef.cocci warnings

Message ID 20220210124658.GA27194@41bd5bfec107 (mailing list archive)
State Not Applicable
Delegated to: Netdev Maintainers
Headers show
Series net: dsa: qca8k: fix noderef.cocci warnings | expand

Checks

Context Check Description
netdev/tree_selection success Not a local patch

Commit Message

kernel test robot Feb. 10, 2022, 12:46 p.m. UTC 
From: kernel test robot <lkp@intel.com>

drivers/net/dsa/qca8k.c:422:37-43: ERROR: application of sizeof to pointer

 sizeof when applied to a pointer typed expression gives the size of
 the pointer

Generated by: scripts/coccinelle/misc/noderef.cocci

Fixes: 90386223f44e ("net: dsa: qca8k: add support for larger read/write size with mgmt Ethernet")
CC: Ansuel Smith <ansuelsmth@gmail.com>
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head:   395a61741f7ea29e1f4a0d6e160197fe8e377572
commit: 90386223f44e2a751d7e9e9ac8f78ea33358a891 [2956/4901] net: dsa: qca8k: add support for larger read/write size with mgmt Ethernet
:::::: branch date: 5 hours ago
:::::: commit date: 8 days ago

 qca8k.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff mbox series

Patch

--- a/drivers/net/dsa/qca8k.c
+++ b/drivers/net/dsa/qca8k.c
@@ -419,7 +419,7 @@  qca8k_regmap_read(void *ctx, uint32_t re
 	u16 r1, r2, page;
 	int ret;
 
-	if (!qca8k_read_eth(priv, reg, val, sizeof(val)))
+	if (!qca8k_read_eth(priv, reg, val, sizeof(*val)))
 		return 0;
 
 	qca8k_split_addr(reg, &r1, &r2, &page);