diff mbox series

[bpf-next] scripts/pahole-flags.sh: Enable parallelization of pahole.

Message ID 20220216004616.2079689-1-kuifeng@fb.com (mailing list archive)
State Superseded
Delegated to: BPF
Headers show
Series [bpf-next] scripts/pahole-flags.sh: Enable parallelization of pahole. | expand

Checks

Context Check Description
bpf/vmtest-bpf-next-PR success PR summary
netdev/tree_selection success Clearly marked for bpf-next
netdev/fixes_present success Fixes tag not required for -next series
netdev/subject_prefix success Link
netdev/cover_letter success Single patches do not need cover letters
netdev/patch_count success Link
netdev/header_inline success No static functions without inline keyword in header files
netdev/build_32bit success Errors and warnings before: 0 this patch: 0
netdev/cc_maintainers warning 6 maintainers not CCed: kpsingh@kernel.org john.fastabend@gmail.com kafai@fb.com songliubraving@fb.com yhs@fb.com netdev@vger.kernel.org
netdev/build_clang success Errors and warnings before: 0 this patch: 0
netdev/module_param success Was 0 now: 0
netdev/verify_signedoff success Signed-off-by tag matches author and committer
netdev/verify_fixes success No Fixes tag
netdev/build_allmodconfig_warn success Errors and warnings before: 0 this patch: 0
netdev/checkpatch success total: 0 errors, 0 warnings, 0 checks, 8 lines checked
netdev/kdoc success Errors and warnings before: 0 this patch: 0
netdev/source_inline success Was 0 now: 0
bpf/vmtest-bpf-next success VM_Test

Commit Message

Kui-Feng Lee Feb. 16, 2022, 12:46 a.m. UTC
Pass a -j argument to pahole to parse DWARF and generate BTF with
multithreading.

Signed-off-by: Kui-Feng Lee <kuifeng@fb.com>
---
 scripts/pahole-flags.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Yonghong Song Feb. 16, 2022, 4:32 a.m. UTC | #1
On 2/15/22 4:46 PM, Kui-Feng Lee wrote:
> Pass a -j argument to pahole to parse DWARF and generate BTF with
> multithreading.
> 
> Signed-off-by: Kui-Feng Lee <kuifeng@fb.com>
> ---
>   scripts/pahole-flags.sh | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/scripts/pahole-flags.sh b/scripts/pahole-flags.sh
> index c293941612e7..73f237ce44e8 100755
> --- a/scripts/pahole-flags.sh
> +++ b/scripts/pahole-flags.sh
> @@ -1,7 +1,7 @@
>   #!/bin/sh
>   # SPDX-License-Identifier: GPL-2.0
>   
> -extra_paholeopt=
> +extra_paholeopt=-j

-j option seems only available for version >= 1.22
(please double check).
The script scripts/pahole-version.sh can be used to
determine the pahole version.

>   
>   if ! [ -x "$(command -v ${PAHOLE})" ]; then
>   	exit 0
Kui-Feng Lee Feb. 16, 2022, 6:12 p.m. UTC | #2
On Tue, 2022-02-15 at 20:32 -0800, Yonghong Song wrote:
> 
> 
> On 2/15/22 4:46 PM, Kui-Feng Lee wrote:
> > Pass a -j argument to pahole to parse DWARF and generate BTF with
> > multithreading.
> > 
> > Signed-off-by: Kui-Feng Lee <kuifeng@fb.com>
> > ---
> >   scripts/pahole-flags.sh | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/scripts/pahole-flags.sh b/scripts/pahole-flags.sh
> > index c293941612e7..73f237ce44e8 100755
> > --- a/scripts/pahole-flags.sh
> > +++ b/scripts/pahole-flags.sh
> > @@ -1,7 +1,7 @@
> >   #!/bin/sh
> >   # SPDX-License-Identifier: GPL-2.0
> >   
> > -extra_paholeopt=
> > +extra_paholeopt=-j
> 
> -j option seems only available for version >= 1.22
> (please double check).
> The script scripts/pahole-version.sh can be used to
> determine the pahole version.
> 

You are right. Thank you for the feedback.
diff mbox series

Patch

diff --git a/scripts/pahole-flags.sh b/scripts/pahole-flags.sh
index c293941612e7..73f237ce44e8 100755
--- a/scripts/pahole-flags.sh
+++ b/scripts/pahole-flags.sh
@@ -1,7 +1,7 @@ 
 #!/bin/sh
 # SPDX-License-Identifier: GPL-2.0
 
-extra_paholeopt=
+extra_paholeopt=-j
 
 if ! [ -x "$(command -v ${PAHOLE})" ]; then
 	exit 0