| Message ID | 20220216014507.109117-1-yang.lee@linux.alibaba.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 8c16baa51beb50e091f6652c47fc1c8501b93611 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [-next] net: Fix an ignored error return from dm9051_get_regs() | expand |
diff --git a/drivers/net/ethernet/davicom/dm9051.c b/drivers/net/ethernet/davicom/dm9051.c index d2513c97f83e..8984363624eb 100644 --- a/drivers/net/ethernet/davicom/dm9051.c +++ b/drivers/net/ethernet/davicom/dm9051.c @@ -519,7 +519,7 @@ static int dm9051_map_init(struct spi_device *spi, struct board_info *db) static int dm9051_map_chipid(struct board_info *db) { struct device *dev = &db->spidev->dev; - unsigned int ret; + int ret; unsigned short wid; u8 buff[6];
The return from the call to dm9051_get_regs() is int, it can be a negative error code, however this is being assigned to an unsigned int variable 'ret', so making 'ret' an int. Eliminate the following coccicheck warning: ./drivers/net/ethernet/davicom/dm9051.c:527:5-8: WARNING: Unsigned expression compared with zero: ret < 0 Reported-by: Abaci Robot <abaci@linux.alibaba.com> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com> --- drivers/net/ethernet/davicom/dm9051.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)