| Message ID | 20220219005221.634-19-bhe@redhat.com (mailing list archive) |
|---|---|
| State | Not Applicable |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | Don't use kmalloc() with GFP_DMA | expand |
On Sat, Feb 19, 2022 at 08:52:17AM +0800, Baoquan He wrote: > dmam_alloc_coherent() uses struct dma_devres to manage data, and call > dma_alloc_attrs() to allocate cohenrent DMA memory, so it's redundent > to specify GFP_DMA when calling. Looks good, Reviewed-by: Christoph Hellwig <hch@lst.de>
diff --git a/drivers/net/ethernet/mediatek/mtk_star_emac.c b/drivers/net/ethernet/mediatek/mtk_star_emac.c index 89ca7960b225..55b95f51ac75 100644 --- a/drivers/net/ethernet/mediatek/mtk_star_emac.c +++ b/drivers/net/ethernet/mediatek/mtk_star_emac.c @@ -1533,7 +1533,7 @@ static int mtk_star_probe(struct platform_device *pdev) priv->ring_base = dmam_alloc_coherent(dev, MTK_STAR_DMA_SIZE, &priv->dma_addr, - GFP_KERNEL | GFP_DMA); + GFP_KERNEL); if (!priv->ring_base) return -ENOMEM;
dmam_alloc_coherent() uses struct dma_devres to manage data, and call dma_alloc_attrs() to allocate cohenrent DMA memory, so it's redundent to specify GFP_DMA when calling. Signed-off-by: Baoquan He <bhe@redhat.com> --- drivers/net/ethernet/mediatek/mtk_star_emac.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)