| Message ID | 20220222042936.516874-1-matt@codeconstruct.com.au (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 8d783197f06d905e5e7a89342e815ef5aeaa1731 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net-next] mctp: Fix warnings reported by clang-analyzer | expand |
Hello: This patch was applied to netdev/net-next.git (master) by David S. Miller <davem@davemloft.net>: On Tue, 22 Feb 2022 12:29:36 +0800 you wrote: > net/mctp/device.c:140:11: warning: Assigned value is garbage or undefined > [clang-analyzer-core.uninitialized.Assign] > mcb->idx = idx; > > - Not a real problem due to how the callback runs, fix the warning. > > net/mctp/route.c:458:4: warning: Value stored to 'msk' is never read > [clang-analyzer-deadcode.DeadStores] > msk = container_of(key->sk, struct mctp_sock, sk); > > [...] Here is the summary with links: - [net-next] mctp: Fix warnings reported by clang-analyzer https://git.kernel.org/netdev/net-next/c/8d783197f06d You are awesome, thank you!
diff --git a/net/mctp/device.c b/net/mctp/device.c index 9e097e61f23a..224f067e9d4c 100644 --- a/net/mctp/device.c +++ b/net/mctp/device.c @@ -107,7 +107,7 @@ static int mctp_dump_addrinfo(struct sk_buff *skb, struct netlink_callback *cb) struct ifaddrmsg *hdr; struct mctp_dev *mdev; int ifindex; - int idx, rc; + int idx = 0, rc; hdr = nlmsg_data(cb->nlh); // filter by ifindex if requested diff --git a/net/mctp/route.c b/net/mctp/route.c index fe6c8bf1ec2c..85acfcbabd9c 100644 --- a/net/mctp/route.c +++ b/net/mctp/route.c @@ -456,7 +456,6 @@ static int mctp_route_input(struct mctp_route *route, struct sk_buff *skb) * the reassembly/response key */ if (!rc && flags & MCTP_HDR_FLAG_EOM) { - msk = container_of(key->sk, struct mctp_sock, sk); sock_queue_rcv_skb(key->sk, key->reasm_head); key->reasm_head = NULL; __mctp_key_done_in(key, net, f, MCTP_TRACE_KEY_REPLIED);
net/mctp/device.c:140:11: warning: Assigned value is garbage or undefined [clang-analyzer-core.uninitialized.Assign] mcb->idx = idx; - Not a real problem due to how the callback runs, fix the warning. net/mctp/route.c:458:4: warning: Value stored to 'msk' is never read [clang-analyzer-deadcode.DeadStores] msk = container_of(key->sk, struct mctp_sock, sk); - 'msk' dead assignment can be removed here. Signed-off-by: Matt Johnston <matt@codeconstruct.com.au> --- net/mctp/device.c | 2 +- net/mctp/route.c | 1 - 2 files changed, 1 insertion(+), 2 deletions(-)