| Message ID | 20220225124528.26506-1-baijiaju1990@gmail.com (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | video: fbdev: via: check the return value of ioremap() in viafb_lcd_get_mobile_state() | expand |
| Context | Check | Description |
|---|---|---|
| netdev/tree_selection | success | Not a local patch |
diff --git a/drivers/video/fbdev/via/lcd.c b/drivers/video/fbdev/via/lcd.c index 088b962076b5..9aa331a4a605 100644 --- a/drivers/video/fbdev/via/lcd.c +++ b/drivers/video/fbdev/via/lcd.c @@ -954,6 +954,8 @@ bool viafb_lcd_get_mobile_state(bool *mobile) u16 start_pattern; biosptr = ioremap(romaddr, 0x10000); + if (!biosptr) + return false; start_pattern = readw(biosptr); /* Compare pattern */
The function ioremap() in viafb_lcd_get_mobile_state() can fail, so its return value should be checked. Fixes: ac6c97e20f1b ("viafb: lcd.c, lcd.h, lcdtbl.h") Reported-by: TOTE Robot <oslab@tsinghua.edu.cn> Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com> --- drivers/video/fbdev/via/lcd.c | 2 ++ 1 file changed, 2 insertions(+)