| Message ID | 20220225125230.26707-1-baijiaju1990@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | d4e26aaea7f82ba884dcb4acfe689406bc092dc3 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | atm: firestream: check the return value of ioremap() in fs_init() | expand |
Hello: This patch was applied to netdev/net.git (master) by David S. Miller <davem@davemloft.net>: On Fri, 25 Feb 2022 04:52:30 -0800 you wrote: > The function ioremap() in fs_init() can fail, so its return value should > be checked. > > Reported-by: TOTE Robot <oslab@tsinghua.edu.cn> > Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com> > --- > drivers/atm/firestream.c | 2 ++ > 1 file changed, 2 insertions(+) Here is the summary with links: - atm: firestream: check the return value of ioremap() in fs_init() https://git.kernel.org/netdev/net/c/d4e26aaea7f8 You are awesome, thank you!
diff --git a/drivers/atm/firestream.c b/drivers/atm/firestream.c index 3bc3c314a467..4f67404fe64c 100644 --- a/drivers/atm/firestream.c +++ b/drivers/atm/firestream.c @@ -1676,6 +1676,8 @@ static int fs_init(struct fs_dev *dev) dev->hw_base = pci_resource_start(pci_dev, 0); dev->base = ioremap(dev->hw_base, 0x1000); + if (!dev->base) + return 1; reset_chip (dev);
The function ioremap() in fs_init() can fail, so its return value should be checked. Reported-by: TOTE Robot <oslab@tsinghua.edu.cn> Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com> --- drivers/atm/firestream.c | 2 ++ 1 file changed, 2 insertions(+)