| Message ID | 20220225201530.182085-1-elder@linaro.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | caef14b7530c065fb85d54492768fa48fdb5093e |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net] net: ipa: fix a build dependency | expand |
On 2/25/22 12:15, Alex Elder wrote: > An IPA build problem arose in the linux-next tree the other day. > The problem is that a recent commit adds a new dependency on some > code, and the Kconfig file for IPA doesn't reflect that dependency. > As a result, some configurations can fail to build (particularly > when COMPILE_TEST is enabled). > > The recent patch adds calls to qmp_get(), qmp_put(), and qmp_send(), > and those are built based on the QCOM_AOSS_QMP config option. If > that symbol is not defined, stubs are defined, so we just need to > ensure QCOM_AOSS_QMP is compatible with QCOM_IPA, or it's not > defined. > > Reported-by: Randy Dunlap <rdunlap@infradead.org> > Fixes: 34a081761e4e3 ("net: ipa: request IPA register values be retained") > Signed-off-by: Alex Elder <elder@linaro.org> Tested-by: Randy Dunlap <rdunlap@infradead.org> Acked-by: Randy Dunlap <rdunlap@infradead.org> thanks. > --- > drivers/net/ipa/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/ipa/Kconfig b/drivers/net/ipa/Kconfig > index d037682fb7adb..e0164a55c1e66 100644 > --- a/drivers/net/ipa/Kconfig > +++ b/drivers/net/ipa/Kconfig > @@ -3,6 +3,7 @@ config QCOM_IPA > depends on NET && QCOM_SMEM > depends on ARCH_QCOM || COMPILE_TEST > depends on QCOM_RPROC_COMMON || (QCOM_RPROC_COMMON=n && COMPILE_TEST) > + depends on QCOM_AOSS_QMP || QCOM_AOSS_QMP=n > select QCOM_MDT_LOADER if ARCH_QCOM > select QCOM_SCM > select QCOM_QMI_HELPERS
Hello: This patch was applied to netdev/net.git (master) by David S. Miller <davem@davemloft.net>: On Fri, 25 Feb 2022 14:15:30 -0600 you wrote: > An IPA build problem arose in the linux-next tree the other day. > The problem is that a recent commit adds a new dependency on some > code, and the Kconfig file for IPA doesn't reflect that dependency. > As a result, some configurations can fail to build (particularly > when COMPILE_TEST is enabled). > > The recent patch adds calls to qmp_get(), qmp_put(), and qmp_send(), > and those are built based on the QCOM_AOSS_QMP config option. If > that symbol is not defined, stubs are defined, so we just need to > ensure QCOM_AOSS_QMP is compatible with QCOM_IPA, or it's not > defined. > > [...] Here is the summary with links: - [net] net: ipa: fix a build dependency https://git.kernel.org/netdev/net/c/caef14b7530c You are awesome, thank you!
diff --git a/drivers/net/ipa/Kconfig b/drivers/net/ipa/Kconfig index d037682fb7adb..e0164a55c1e66 100644 --- a/drivers/net/ipa/Kconfig +++ b/drivers/net/ipa/Kconfig @@ -3,6 +3,7 @@ config QCOM_IPA depends on NET && QCOM_SMEM depends on ARCH_QCOM || COMPILE_TEST depends on QCOM_RPROC_COMMON || (QCOM_RPROC_COMMON=n && COMPILE_TEST) + depends on QCOM_AOSS_QMP || QCOM_AOSS_QMP=n select QCOM_MDT_LOADER if ARCH_QCOM select QCOM_SCM select QCOM_QMI_HELPERS
An IPA build problem arose in the linux-next tree the other day. The problem is that a recent commit adds a new dependency on some code, and the Kconfig file for IPA doesn't reflect that dependency. As a result, some configurations can fail to build (particularly when COMPILE_TEST is enabled). The recent patch adds calls to qmp_get(), qmp_put(), and qmp_send(), and those are built based on the QCOM_AOSS_QMP config option. If that symbol is not defined, stubs are defined, so we just need to ensure QCOM_AOSS_QMP is compatible with QCOM_IPA, or it's not defined. Reported-by: Randy Dunlap <rdunlap@infradead.org> Fixes: 34a081761e4e3 ("net: ipa: request IPA register values be retained") Signed-off-by: Alex Elder <elder@linaro.org> --- drivers/net/ipa/Kconfig | 1 + 1 file changed, 1 insertion(+)