| Message ID | 20220303182508.288136-6-miquel.raynal@bootlin.com (mailing list archive) |
|---|---|
| State | Awaiting Upstream |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | ieee802154: Better Tx error handling | expand |
Hi, On Thu, Mar 3, 2022 at 1:25 PM Miquel Raynal <miquel.raynal@bootlin.com> wrote: > > The TRAC register gives the MAC error codes if any. If the TRAC register > reports a value that is unknown, we should probably assume that it is > invalid. > Can we instead revert 493bc90a9683 ("at86rf230: add debugfs support") it was introduced because of some testing stuff with ack handling but now we have an error. We might add a stats handling for such errors in the 802.15.4 core in future to get it on a per neighbor basis. - Alex
diff --git a/drivers/net/ieee802154/at86rf230.c b/drivers/net/ieee802154/at86rf230.c index 563031ce76f0..616acfa8cd28 100644 --- a/drivers/net/ieee802154/at86rf230.c +++ b/drivers/net/ieee802154/at86rf230.c @@ -694,6 +694,7 @@ at86rf230_tx_trac_check(void *context) break; default: WARN_ONCE(1, "received tx trac status %d\n", trac); + lp->trac.invalid++; break; } }
The TRAC register gives the MAC error codes if any. If the TRAC register reports a value that is unknown, we should probably assume that it is invalid. Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com> --- drivers/net/ieee802154/at86rf230.c | 1 + 1 file changed, 1 insertion(+)