| Message ID | 20220304083653.66238-1-jiapeng.chong@linux.alibaba.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 1039135aedfc5021b4827eb87276d7b4272024ac |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [v2] net: ethernet: sun: Remove redundant code | expand |
Hello: This patch was applied to netdev/net-next.git (master) by David S. Miller <davem@davemloft.net>: On Fri, 4 Mar 2022 16:36:53 +0800 you wrote: > Since the starting value in the for loop is greater than or equal to 1, > the restriction is CAS_FLAG_REG_PLUS is in the file cassini.h is > defined as 0x1 by macro, and the for loop and if condition is not > satisfied, so the code here is redundant. > > Clean up the following smatch warning: > > [...] Here is the summary with links: - [v2] net: ethernet: sun: Remove redundant code https://git.kernel.org/netdev/net-next/c/1039135aedfc You are awesome, thank you!
On Fri, Mar 04, 2022 at 04:36:53PM +0800, Jiapeng Chong wrote: > Since the starting value in the for loop is greater than or equal to 1, > the restriction is CAS_FLAG_REG_PLUS is in the file cassini.h is > defined as 0x1 by macro, and the for loop and if condition is not > satisfied, so the code here is redundant. This still does not make much sense. Too late, David has merged it. Taking a deeper look, we see: https://elixir.bootlin.com/linux/v5.17-rc6/source/drivers/net/ethernet/sun/cassini.h#L2542 #define N_RX_COMP_RINGS 0x1 /* for mult. PCI interrupts */ So what the bot is reporting: > drivers/net/ethernet/sun/cassini.c:3513 cas_start_dma() warn: we never > enter this loop. > > drivers/net/ethernet/sun/cassini.c:1239 cas_init_rx_dma() warn: we never > enter this loop. > > drivers/net/ethernet/sun/cassini.c:1247 cas_init_rx_dma() warn: we never > enter this loop. > > - if (cp->cas_flags & CAS_FLAG_REG_PLUS) { > - for (i = 1; i < N_RX_COMP_RINGS; i++) > - readl(cp->regs + REG_PLUS_INTRN_STATUS_ALIAS(i)); has nothing to do with CAS_FLAG_REG_PLUS, which you say in your commit message. It has to do with N_RX_COMP_RINGS. So you have 'fixed' a bots warning by removing code which cannot be used. But is this the correct fix? Or has the bot actually found a bug? Don't you think somebody wrote this code expecting it to be used? Or do you think people write extra code which will never be used for fun? Looking at the git history, this code was actually written by DaveM. Dave, this very old code, do you still remember this hardware? Bug or dead code? Andrew
diff --git a/drivers/net/ethernet/sun/cassini.c b/drivers/net/ethernet/sun/cassini.c index 947a76a788c7..153edc5eadad 100644 --- a/drivers/net/ethernet/sun/cassini.c +++ b/drivers/net/ethernet/sun/cassini.c @@ -1235,19 +1235,6 @@ static void cas_init_rx_dma(struct cas *cp) */ readl(cp->regs + REG_INTR_STATUS_ALIAS); writel(INTR_RX_DONE | INTR_RX_BUF_UNAVAIL, cp->regs + REG_ALIAS_CLEAR); - if (cp->cas_flags & CAS_FLAG_REG_PLUS) { - for (i = 1; i < N_RX_COMP_RINGS; i++) - readl(cp->regs + REG_PLUS_INTRN_STATUS_ALIAS(i)); - - /* 2 is different from 3 and 4 */ - if (N_RX_COMP_RINGS > 1) - writel(INTR_RX_DONE_ALT | INTR_RX_BUF_UNAVAIL_1, - cp->regs + REG_PLUS_ALIASN_CLEAR(1)); - - for (i = 2; i < N_RX_COMP_RINGS; i++) - writel(INTR_RX_DONE_ALT, - cp->regs + REG_PLUS_ALIASN_CLEAR(i)); - } /* set up pause thresholds */ val = CAS_BASE(RX_PAUSE_THRESH_OFF, @@ -3509,9 +3496,6 @@ static inline void cas_start_dma(struct cas *cp) if (N_RX_DESC_RINGS > 1) writel(RX_DESC_RINGN_SIZE(1) - 4, cp->regs + REG_PLUS_RX_KICK1); - - for (i = 1; i < N_RX_COMP_RINGS; i++) - writel(0, cp->regs + REG_PLUS_RX_COMPN_TAIL(i)); } }
Since the starting value in the for loop is greater than or equal to 1, the restriction is CAS_FLAG_REG_PLUS is in the file cassini.h is defined as 0x1 by macro, and the for loop and if condition is not satisfied, so the code here is redundant. Clean up the following smatch warning: drivers/net/ethernet/sun/cassini.c:3513 cas_start_dma() warn: we never enter this loop. drivers/net/ethernet/sun/cassini.c:1239 cas_init_rx_dma() warn: we never enter this loop. drivers/net/ethernet/sun/cassini.c:1247 cas_init_rx_dma() warn: we never enter this loop. Reported-by: Abaci Robot <abaci@linux.alibaba.com> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com> --- Changes in v2: -Expand this comment. drivers/net/ethernet/sun/cassini.c | 16 ---------------- 1 file changed, 16 deletions(-)