| Message ID | 20220305161013.361646-1-ytcoode@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 4989135a85334337ac8b7e42e7ee1a569ad5f7f5 |
| Delegated to: | BPF |
| Headers | show |
| Series | [bpf-next] bpf: Remove redundant slash | expand |
| Context | Check | Description |
|---|---|---|
| netdev/tree_selection | success | Clearly marked for bpf-next |
| netdev/fixes_present | success | Fixes tag not required for -next series |
| netdev/subject_prefix | success | Link |
| netdev/cover_letter | success | Single patches do not need cover letters |
| netdev/patch_count | success | Link |
| netdev/header_inline | success | No static functions without inline keyword in header files |
| netdev/build_32bit | success | Errors and warnings before: 0 this patch: 0 |
| netdev/cc_maintainers | success | CCed 11 of 11 maintainers |
| netdev/build_clang | success | Errors and warnings before: 0 this patch: 0 |
| netdev/module_param | success | Was 0 now: 0 |
| netdev/verify_signedoff | success | Signed-off-by tag matches author and committer |
| netdev/verify_fixes | success | No Fixes tag |
| netdev/build_allmodconfig_warn | success | Errors and warnings before: 0 this patch: 0 |
| netdev/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 7 lines checked |
| netdev/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| netdev/source_inline | success | Was 0 now: 0 |
| bpf/vmtest-bpf-next | success | VM_Test |
| bpf/vmtest-bpf-next-PR | fail | merge-conflict |
2022-03-06 00:10 UTC+0800 ~ Yuntao Wang <ytcoode@gmail.com> > The trailing slash of LIBBPF_SRCS is redundant, remove it. > > Signed-off-by: Yuntao Wang <ytcoode@gmail.com> > --- > kernel/bpf/preload/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/kernel/bpf/preload/Makefile b/kernel/bpf/preload/Makefile > index 167534e3b0b4..7b62b3e2bf6d 100644 > --- a/kernel/bpf/preload/Makefile > +++ b/kernel/bpf/preload/Makefile > @@ -1,6 +1,6 @@ > # SPDX-License-Identifier: GPL-2.0 > > -LIBBPF_SRCS = $(srctree)/tools/lib/bpf/ > +LIBBPF_SRCS = $(srctree)/tools/lib/bpf > LIBBPF_INCLUDE = $(LIBBPF_SRCS)/.. > > obj-$(CONFIG_BPF_PRELOAD_UMD) += bpf_preload.o Looks good to me, but we could maybe just as well get rid of LIBBPF_SRCS in this file?: LIBBPF_INCLUDE = $(srctree)/tools/lib Quentin
On Mon, Mar 7, 2022 at 9:06 AM Quentin Monnet <quentin@isovalent.com> wrote: > > 2022-03-06 00:10 UTC+0800 ~ Yuntao Wang <ytcoode@gmail.com> > > The trailing slash of LIBBPF_SRCS is redundant, remove it. > > > > Signed-off-by: Yuntao Wang <ytcoode@gmail.com> > > --- > > kernel/bpf/preload/Makefile | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/kernel/bpf/preload/Makefile b/kernel/bpf/preload/Makefile > > index 167534e3b0b4..7b62b3e2bf6d 100644 > > --- a/kernel/bpf/preload/Makefile > > +++ b/kernel/bpf/preload/Makefile > > @@ -1,6 +1,6 @@ > > # SPDX-License-Identifier: GPL-2.0 > > > > -LIBBPF_SRCS = $(srctree)/tools/lib/bpf/ > > +LIBBPF_SRCS = $(srctree)/tools/lib/bpf > > LIBBPF_INCLUDE = $(LIBBPF_SRCS)/.. > > > > obj-$(CONFIG_BPF_PRELOAD_UMD) += bpf_preload.o > > Looks good to me, but we could maybe just as well get rid of LIBBPF_SRCS > in this file?: > > LIBBPF_INCLUDE = $(srctree)/tools/lib yep, I inlined this and ended up with just LIBBPF_INCLUDE = $(srctree)/tools/lib Applied to bpf-next, thanks. > > Quentin
Hello: This patch was applied to bpf/bpf-next.git (master) by Andrii Nakryiko <andrii@kernel.org>: On Sun, 6 Mar 2022 00:10:13 +0800 you wrote: > The trailing slash of LIBBPF_SRCS is redundant, remove it. > > Signed-off-by: Yuntao Wang <ytcoode@gmail.com> > --- > kernel/bpf/preload/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Here is the summary with links: - [bpf-next] bpf: Remove redundant slash https://git.kernel.org/bpf/bpf-next/c/4989135a8533 You are awesome, thank you!
diff --git a/kernel/bpf/preload/Makefile b/kernel/bpf/preload/Makefile index 167534e3b0b4..7b62b3e2bf6d 100644 --- a/kernel/bpf/preload/Makefile +++ b/kernel/bpf/preload/Makefile @@ -1,6 +1,6 @@ # SPDX-License-Identifier: GPL-2.0 -LIBBPF_SRCS = $(srctree)/tools/lib/bpf/ +LIBBPF_SRCS = $(srctree)/tools/lib/bpf LIBBPF_INCLUDE = $(LIBBPF_SRCS)/.. obj-$(CONFIG_BPF_PRELOAD_UMD) += bpf_preload.o
The trailing slash of LIBBPF_SRCS is redundant, remove it. Signed-off-by: Yuntao Wang <ytcoode@gmail.com> --- kernel/bpf/preload/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)